Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch concurrent schema/table creation #283

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Catch concurrent schema/table creation #283

merged 3 commits into from
Jan 20, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 19, 2022

@AlekSi AlekSi added the code/bug Some user-visible feature works incorrectly label Jan 19, 2022
@AlekSi AlekSi added this to the v0.0.6 milestone Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #283 (5e22df8) into main (3ef6cc2) will increase coverage by 0.12%.
The diff coverage is 80.76%.

❗ Current head 5e22df8 differs from pull request most recent head e5852b4. Consider uploading reports for the commit e5852b4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   51.05%   51.18%   +0.12%     
==========================================
  Files         112      112              
  Lines        5347     5371      +24     
==========================================
+ Hits         2730     2749      +19     
- Misses       2205     2210       +5     
  Partials      412      412              
Impacted Files Coverage Δ
internal/handlers/handler.go 50.34% <0.00%> (-1.05%) ⬇️
internal/pg/pool.go 76.36% <86.36%> (+0.12%) ⬆️
internal/handlers/msg_dbstats.go 75.00% <100.00%> (ø)
internal/util/testutil/testutil.go 82.66% <100.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef6cc2...e5852b4. Read the comment docs.

@AlekSi AlekSi marked this pull request as ready for review January 20, 2022 08:37
@AlekSi AlekSi enabled auto-merge (squash) January 20, 2022 09:10
@AlekSi AlekSi merged commit 7bb5433 into main Jan 20, 2022
@AlekSi AlekSi deleted the concurrent-create branch January 20, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate parallels Ferret tests failures
1 participant