Allow $set operator to update _id
#3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
===========================================
- Coverage 76.25% 51.19% -25.07%
===========================================
Files 385 385
Lines 21060 21042 -18
===========================================
- Hits 16060 10773 -5287
- Misses 4076 9533 +5457
+ Partials 924 736 -188
... and 123 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
commented
Jul 10, 2023
chilagrow
changed the title
$set operator for updating _id
chilagrow
requested review from
AlekSi,
rumyantseva,
a team,
quasilyte and
noisersup
rumyantseva
reviewed
Jul 10, 2023
rumyantseva
requested changes
Jul 10, 2023
There was a problem hiding this comment.
I understand why you changed these functions the way you did, but I think we need to find a better design as the current approach is too confusing with having extra params that are needed only once and for a particular case. I don't have a clear idea of a better design, but I'm available for pair programming.
chilagrow
changed the title
$set operator for updating _id$set operator to update _id
rumyantseva
approved these changes
Jul 10, 2023
|
should be reopened, incomplete fix see #2803 (comment) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2803.
Scope changed, because of #3013 we decided to remove validation.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.