Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue URL #3021

Merged
merged 2 commits into from Jul 10, 2023
Merged

Update issue URL #3021

merged 2 commits into from Jul 10, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 10, 2023

Description

The old issue was a duplicate.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 10, 2023
@AlekSi AlekSi added this to the Next milestone Jul 10, 2023
@AlekSi AlekSi self-assigned this Jul 10, 2023
@AlekSi AlekSi requested a review from a team as a code owner July 10, 2023 14:08
@AlekSi AlekSi enabled auto-merge (squash) July 10, 2023 14:08
@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 10, 2023 14:08
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #3021 (0348bc4) into main (d50e794) will increase coverage by 2.94%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
+ Coverage   71.24%   74.18%   +2.94%     
==========================================
  Files         385      385              
  Lines       21042    21045       +3     
==========================================
+ Hits        14991    15613     +622     
+ Misses       5117     4480     -637     
- Partials      934      952      +18     
Impacted Files Coverage Δ
internal/handlers/pg/msg_find.go 87.32% <100.00%> (+2.21%) ⬆️
internal/handlers/sqlite/msg_find.go 92.39% <100.00%> (+0.16%) ⬆️

... and 58 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 70.56% <100.00%> (+2.97%) ⬆️
mongodb 5.34% <0.00%> (-0.01%) ⬇️
pg 60.68% <50.00%> (+2.21%) ⬆️
shard-1 55.21% <100.00%> (+<0.01%) ⬆️
shard-2 36.43% <50.00%> (-13.05%) ⬇️
shard-3 56.70% <100.00%> (+20.26%) ⬆️
sqlite 45.86% <50.00%> (+3.96%) ⬆️
unit 24.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 7f4d831 into FerretDB:main Jul 10, 2023
24 of 27 checks passed
@AlekSi AlekSi deleted the fix-url branch July 10, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants