Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test doubles with constants #3024

Merged
merged 28 commits into from Jul 24, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jul 10, 2023

Description

Closes #2321.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Jul 10, 2023
@noisersup noisersup added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #3024 (6b9d04f) into main (110cfa0) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
- Coverage   76.61%   76.54%   -0.08%     
==========================================
  Files         388      388              
  Lines       21287    21292       +5     
==========================================
- Hits        16310    16297      -13     
- Misses       4052     4066      +14     
- Partials      925      929       +4     
Impacted Files Coverage Δ
integration/shareddata/scalars.go 100.00% <100.00%> (ø)
internal/handlers/common/filter.go 85.19% <100.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 73.11% <100.00%> (-0.10%) ⬇️
mongodb 5.49% <83.33%> (+0.02%) ⬆️
pg 66.44% <100.00%> (-0.03%) ⬇️
shard-1 56.97% <83.33%> (-0.06%) ⬇️
shard-2 55.15% <83.33%> (+<0.01%) ⬆️
shard-3 57.18% <100.00%> (-0.01%) ⬇️
sqlite 46.48% <100.00%> (-0.06%) ⬇️
unit 24.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 12, 2023
@noisersup noisersup marked this pull request as ready for review July 12, 2023 21:29
@noisersup noisersup requested review from a team and AlekSi as code owners July 12, 2023 21:29
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! Few comments 🤗

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from chilagrow July 13, 2023 11:49
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
@chilagrow
Copy link
Contributor

Tests failing for TestQueryBitwise*

rumyantseva
rumyantseva previously approved these changes Jul 17, 2023
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chilagrow
chilagrow previously approved these changes Jul 18, 2023
@noisersup noisersup enabled auto-merge (squash) July 18, 2023 08:40
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi AlekSi requested review from a team July 19, 2023 16:46
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
integration/shareddata/scalars.go Outdated Show resolved Hide resolved
chilagrow
chilagrow previously approved these changes Jul 20, 2023
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from existing comment, looks good to me

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi added this to the Next milestone Jul 21, 2023
@noisersup noisersup merged commit 68e5663 into FerretDB:main Jul 24, 2023
33 of 48 checks passed
@noisersup noisersup deleted the use-constants-2321 branch July 24, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace all weird numbers with constant values
5 participants