Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace test doubles with constants #3024

Merged
merged 28 commits into from
Jul 24, 2023
Merged

Replace test doubles with constants #3024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3a76c7a
first number source found!
noisersup Jul 10, 2023
7040f9a
wip
noisersup Jul 11, 2023
3202aa0
wip
noisersup Jul 11, 2023
a56afe8
wip
noisersup Jul 11, 2023
573983b
wip
noisersup Jul 11, 2023
bf7fe5a
wip
noisersup Jul 11, 2023
56b0f75
some debugging
noisersup Jul 12, 2023
ca33fed
wip
noisersup Jul 12, 2023
277e44d
wip
noisersup Jul 12, 2023
ede1002
wip
noisersup Jul 12, 2023
059fc9e
wip
noisersup Jul 12, 2023
6d53c55
wip
noisersup Jul 12, 2023
c5b2188
wip
noisersup Jul 12, 2023
65c9710
wip
noisersup Jul 13, 2023
4b7e5b6
apply comment
noisersup Jul 14, 2023
a2c69e9
apply comment
noisersup Jul 14, 2023
6658457
apply comment
noisersup Jul 14, 2023
4b1192e
lint
noisersup Jul 14, 2023
d616ea4
fix tests
noisersup Jul 14, 2023
034a144
Merge remote-tracking branch 'upstream/main' into use-constants-2321
noisersup Jul 14, 2023
ac63e6e
lint
noisersup Jul 14, 2023
597f380
Update integration/shareddata/scalars.go
noisersup Jul 18, 2023
ca89104
rm type
noisersup Jul 19, 2023
d5d2fd1
wip
noisersup Jul 19, 2023
2dc6f15
wip
noisersup Jul 19, 2023
ac2f89a
Update integration/shareddata/scalars.go
noisersup Jul 20, 2023
082df73
Update integration/shareddata/scalars.go
noisersup Jul 20, 2023
6b9d04f
Merge branch 'main' into use-constants-2321
AlekSi Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,14 @@ In most cases, they should be used instead of (deprecated) `bson.D.Map()`,
The bar for adding new helpers is very high.
Please check all existing ones.

If there's a need to use any large number to test corner cases,
we create constants for them with explanation what do they represent, and refer to them.
For example:

```go
const doubleMaxPrec = float64(1<<53 - 1) // 9007199254740991.0: largest double values that could be represented as integer exactly
chilagrow marked this conversation as resolved.
Show resolved Hide resolved
```

#### Integration tests naming guidelines

1. Test names should include the name of the command being tested.
Expand Down
74 changes: 37 additions & 37 deletions integration/query_bitwise_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ func TestQueryBitwiseAllClear(t *testing.T) {
"Array": {
value: primitive.A{1, 5},
expectedIDs: []any{
"double-1", "double-2", "double-4",
"double-big", "double-min-overflow-verge", "double-zero",
"double-1", "double-3",
"double-big", "double-zero",
"int32-min", "int32-zero",
"int64-3", "int64-big", "int64-double-big",
"int64-min", "int64-zero",
Expand All @@ -73,8 +73,8 @@ func TestQueryBitwiseAllClear(t *testing.T) {
"ArrayFloatWholeBitPositionValue": {
value: primitive.A{1.0},
expectedIDs: []any{
"double-1", "double-2", "double-4", "double-big",
"double-min-overflow-verge", "double-zero",
"double-1", "double-3", "double-big",
"double-zero",
"int32-1", "int32-2", "int32-3", "int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3", "int64-big",
"int64-double-big", "int64-min", "int64-zero",
Expand Down Expand Up @@ -108,8 +108,8 @@ func TestQueryBitwiseAllClear(t *testing.T) {
"DoubleWhole": {
value: 2.0,
expectedIDs: []any{
"double-1", "double-2", "double-4",
"double-big", "double-min-overflow-verge", "double-zero",
"double-1", "double-3",
"double-big", "double-zero",
"int32-1", "int32-2", "int32-3", "int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3",
"int64-big", "int64-double-big", "int64-min", "int64-zero",
Expand Down Expand Up @@ -137,8 +137,8 @@ func TestQueryBitwiseAllClear(t *testing.T) {
"Binary": {
value: primitive.Binary{Data: []byte{2}},
expectedIDs: []any{
"double-1", "double-2", "double-4",
"double-big", "double-min-overflow-verge", "double-zero",
"double-1", "double-3",
"double-big", "double-zero",
"int32-1", "int32-2", "int32-3", "int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3",
"int64-big", "int64-double-big", "int64-min", "int64-zero",
Expand All @@ -147,8 +147,8 @@ func TestQueryBitwiseAllClear(t *testing.T) {
"BinaryWithZeroBytes": {
value: primitive.Binary{Data: []byte{0, 0, 2}},
expectedIDs: []any{
"double-1", "double-2", "double-3", "double-big",
"double-min-overflow-verge", "double-whole", "double-zero",
"double-1", "double-2", "double-big",
"double-whole", "double-zero",
"int32", "int32-1", "int32-min", "int32-zero",
"int64", "int64-1", "int64-big", "int64-double-big",
"int64-min", "int64-zero",
Expand All @@ -166,8 +166,8 @@ func TestQueryBitwiseAllClear(t *testing.T) {
"Int32": {
value: int32(2),
expectedIDs: []any{
"double-1", "double-2", "double-4", "double-big",
"double-min-overflow-verge", "double-zero",
"double-1", "double-3", "double-big",
"double-zero",
"int32-1", "int32-2", "int32-3",
"int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3", "int64-big",
Expand All @@ -186,8 +186,8 @@ func TestQueryBitwiseAllClear(t *testing.T) {
"Int64Max": {
value: math.MaxInt64,
expectedIDs: []any{
"double-1", "double-2",
"double-min-overflow-verge", "double-zero",
"double-1",
"double-zero",
"int32-zero",
"int64-min",
"int64-zero",
Expand Down Expand Up @@ -255,7 +255,7 @@ func TestQueryBitwiseAllSet(t *testing.T) {
}{
"Array": {
value: primitive.A{1, 5},
expectedIDs: []any{"double-3", "double-whole", "int32", "int32-max", "int64", "int64-max"},
expectedIDs: []any{"double-2", "double-whole", "int32", "int32-max", "int64", "int64-max"},
},
"ArrayNegativeBitPositionValue": {
value: primitive.A{-1},
Expand Down Expand Up @@ -284,7 +284,7 @@ func TestQueryBitwiseAllSet(t *testing.T) {
},
"DoubleWhole": {
value: 2.0,
expectedIDs: []any{"double-3", "double-whole", "int32", "int32-max", "int64", "int64-max"},
expectedIDs: []any{"double-2", "double-whole", "int32", "int32-max", "int64", "int64-max"},
},
"DoubleNegativeValue": {
value: -1.0,
Expand All @@ -307,16 +307,16 @@ func TestQueryBitwiseAllSet(t *testing.T) {

"Binary": {
value: primitive.Binary{Data: []byte{2}},
expectedIDs: []any{"double-3", "double-whole", "int32", "int32-max", "int64", "int64-max"},
expectedIDs: []any{"double-2", "double-whole", "int32", "int32-max", "int64", "int64-max"},
},
"BinaryWithZeroBytes": {
value: primitive.Binary{Data: []byte{0, 0, 2}},
expectedIDs: []any{"double-4", "int32-2", "int32-3", "int32-max", "int64-2", "int64-3", "int64-max"},
expectedIDs: []any{"double-3", "int32-2", "int32-3", "int32-max", "int64-2", "int64-3", "int64-max"},
},

"Int32": {
value: int32(2),
expectedIDs: []any{"double-3", "double-whole", "int32", "int32-max", "int64", "int64-max"},
expectedIDs: []any{"double-2", "double-whole", "int32", "int32-max", "int64", "int64-max"},
},
"Int32NegativeValue": {
value: int32(-1),
Expand Down Expand Up @@ -394,8 +394,8 @@ func TestQueryBitwiseAnyClear(t *testing.T) {
"Array": {
value: primitive.A{1, 5},
expectedIDs: []any{
"double-1", "double-2", "double-4",
"double-big", "double-min-overflow-verge", "double-zero",
"double-1", "double-3",
"double-big", "double-zero",
"int32-1", "int32-2", "int32-3",
"int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3",
Expand Down Expand Up @@ -430,8 +430,8 @@ func TestQueryBitwiseAnyClear(t *testing.T) {
"DoubleWhole": {
value: 2.0,
expectedIDs: []any{
"double-1", "double-2", "double-4",
"double-big", "double-min-overflow-verge", "double-zero",
"double-1", "double-3",
"double-big", "double-zero",
"int32-1", "int32-2", "int32-3",
"int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3",
Expand Down Expand Up @@ -460,8 +460,8 @@ func TestQueryBitwiseAnyClear(t *testing.T) {
"Binary": {
value: primitive.Binary{Data: []byte{2}},
expectedIDs: []any{
"double-1", "double-2", "double-4",
"double-big", "double-min-overflow-verge", "double-zero",
"double-1", "double-3",
"double-big", "double-zero",
"int32-1", "int32-2", "int32-3",
"int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3",
Expand All @@ -471,8 +471,8 @@ func TestQueryBitwiseAnyClear(t *testing.T) {
"BinaryWithZeroBytes": {
value: primitive.Binary{Data: []byte{0, 0, 2}},
expectedIDs: []any{
"double-1", "double-2", "double-3",
"double-big", "double-min-overflow-verge", "double-whole", "double-zero",
"double-1", "double-2",
"double-big", "double-whole", "double-zero",
"int32", "int32-1", "int32-min", "int32-zero",
"int64", "int64-1", "int64-big", "int64-double-big",
"int64-min", "int64-zero",
Expand All @@ -482,8 +482,8 @@ func TestQueryBitwiseAnyClear(t *testing.T) {
"Int32": {
value: int32(2),
expectedIDs: []any{
"double-1", "double-2", "double-4",
"double-big", "double-min-overflow-verge", "double-zero",
"double-1", "double-3",
"double-big", "double-zero",
"int32-1", "int32-2", "int32-3",
"int32-min", "int32-zero",
"int64-1", "int64-2", "int64-3",
Expand All @@ -502,8 +502,8 @@ func TestQueryBitwiseAnyClear(t *testing.T) {
"Int64Max": {
value: math.MaxInt64,
expectedIDs: []any{
"double-1", "double-2", "double-3", "double-4",
"double-big", "double-min-overflow-verge", "double-whole", "double-zero",
"double-1", "double-2", "double-3",
"double-big", "double-whole", "double-zero",
"int32", "int32-1", "int32-2", "int32-3", "int32-max", "int32-min", "int32-zero",
"int64", "int64-1", "int64-2", "int64-3", "int64-big", "int64-double-big",
"int64-min", "int64-zero",
Expand Down Expand Up @@ -572,7 +572,7 @@ func TestQueryBitwiseAnySet(t *testing.T) {
"Array": {
value: primitive.A{1, 5},
expectedIDs: []any{
"double-3", "double-whole",
"double-2", "double-whole",
"int32", "int32-1", "int32-2", "int32-3", "int32-max",
"int64", "int64-1", "int64-2", "int64-max",
},
Expand Down Expand Up @@ -605,7 +605,7 @@ func TestQueryBitwiseAnySet(t *testing.T) {
"DoubleWhole": {
value: 2.0,
expectedIDs: []any{
"double-3", "double-whole",
"double-2", "double-whole",
"int32", "int32-max",
"int64", "int64-max",
},
Expand All @@ -631,17 +631,17 @@ func TestQueryBitwiseAnySet(t *testing.T) {

"Binary": {
value: primitive.Binary{Data: []byte{2}},
expectedIDs: []any{"double-3", "double-whole", "int32", "int32-max", "int64", "int64-max"},
expectedIDs: []any{"double-2", "double-whole", "int32", "int32-max", "int64", "int64-max"},
},
"BinaryWithZeroBytes": {
value: primitive.Binary{Data: []byte{0, 0, 2}},
expectedIDs: []any{"double-4", "int32-2", "int32-3", "int32-max", "int64-2", "int64-3", "int64-max"},
expectedIDs: []any{"double-3", "int32-2", "int32-3", "int32-max", "int64-2", "int64-3", "int64-max"},
},

"Int32": {
value: int32(2),
expectedIDs: []any{
"double-3", "double-whole",
"double-2", "double-whole",
"int32", "int32-max",
"int64", "int64-max",
},
Expand All @@ -658,7 +658,7 @@ func TestQueryBitwiseAnySet(t *testing.T) {
"Int64Max": {
value: math.MaxInt64,
expectedIDs: []any{
"double-3", "double-4",
"double-2", "double-3",
"double-big", "double-whole",
"int32", "int32-1", "int32-2", "int32-3", "int32-max", "int32-min",
"int64", "int64-1", "int64-2", "int64-3", "int64-big",
Expand Down
Loading
Loading