Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix killCursors edge case #3030

Merged
merged 14 commits into from
Jul 12, 2023
Merged

Fix killCursors edge case #3030

merged 14 commits into from
Jul 12, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 11, 2023

Description

Closes #1514.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Jul 11, 2023
@AlekSi AlekSi added this to the Next milestone Jul 11, 2023
@AlekSi AlekSi changed the title Fix kill cursors Fix killCursors edge case Jul 11, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #3030 (6a7be1a) into main (f5deeb7) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
- Coverage   76.48%   76.43%   -0.06%     
==========================================
  Files         386      386              
  Lines       21107    21110       +3     
==========================================
- Hits        16144    16135       -9     
- Misses       4048     4057       +9     
- Partials      915      918       +3     
Impacted Files Coverage Δ
internal/handlers/common/killcursors.go 80.88% <100.00%> (+0.88%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.94% <100.00%> (-0.07%) ⬇️
mongodb 5.41% <0.00%> (-0.01%) ⬇️
pg 66.35% <100.00%> (-0.03%) ⬇️
shard-1 54.25% <100.00%> (+0.01%) ⬆️
shard-2 55.73% <0.00%> (-0.08%) ⬇️
shard-3 57.05% <100.00%> (-0.02%) ⬇️
sqlite 46.54% <100.00%> (-0.04%) ⬇️
unit 24.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review July 11, 2023 15:48
@AlekSi AlekSi requested a review from a team as a code owner July 11, 2023 15:48
@AlekSi AlekSi enabled auto-merge (squash) July 11, 2023 15:48
@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 11, 2023 15:48
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@AlekSi AlekSi merged commit f38331f into FerretDB:main Jul 12, 2023
25 of 28 checks passed
@AlekSi AlekSi deleted the fix-kill-cursors branch July 12, 2023 05:35
AlekSi added a commit to AlekSi/FerretDB that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement killCursors command
3 participants