Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error checking in backend contracts #3031

Merged
merged 3 commits into from Jul 12, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 11, 2023

Description

defer was used incorrectly.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 11, 2023
@AlekSi AlekSi added this to the Next milestone Jul 11, 2023
@AlekSi AlekSi self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #3031 (0cb6140) into main (f38331f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
+ Coverage   74.19%   74.27%   +0.07%     
==========================================
  Files         386      386              
  Lines       21110    21120      +10     
==========================================
+ Hits        15663    15686      +23     
+ Misses       4494     4481      -13     
  Partials      953      953              
Impacted Files Coverage Δ
internal/backends/backend.go 100.00% <100.00%> (ø)
internal/backends/collection.go 100.00% <100.00%> (ø)
internal/backends/database.go 100.00% <100.00%> (ø)
internal/backends/error.go 62.85% <100.00%> (+12.85%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 70.67% <95.74%> (+0.06%) ⬆️
mongodb 5.41% <0.00%> (-0.01%) ⬇️
pg 60.43% <0.00%> (-0.03%) ⬇️
shard-1 54.21% <95.74%> (+0.03%) ⬆️
shard-2 36.87% <95.74%> (+0.03%) ⬆️
shard-3 57.10% <95.74%> (+0.07%) ⬆️
sqlite 46.53% <95.74%> (+0.07%) ⬆️
unit 24.23% <4.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review July 11, 2023 17:42
@AlekSi AlekSi enabled auto-merge (squash) July 11, 2023 17:42
internal/backends/backend.go Show resolved Hide resolved
@AlekSi AlekSi requested a review from chilagrow July 12, 2023 05:45
@AlekSi AlekSi merged commit a718823 into FerretDB:main Jul 12, 2023
25 of 28 checks passed
@AlekSi AlekSi deleted the fix-error-check branch July 12, 2023 05:51
AlekSi added a commit to AlekSi/FerretDB that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants