Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not import commonerrors in tests #3081

Merged
merged 2 commits into from Jul 20, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 19, 2023

Description

We use values in all other tests.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 19, 2023
@AlekSi AlekSi added this to the Next milestone Jul 19, 2023
@AlekSi AlekSi self-assigned this Jul 19, 2023
@AlekSi AlekSi requested a review from a team as a code owner July 19, 2023 13:58
@AlekSi AlekSi enabled auto-merge (squash) July 19, 2023 13:58
@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 19, 2023 13:58
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #3081 (b76bb0f) into main (4d534d6) will decrease coverage by 3.33%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3081      +/-   ##
==========================================
- Coverage   76.66%   73.34%   -3.33%     
==========================================
  Files         388      388              
  Lines       21297    21297              
==========================================
- Hits        16328    15620     -708     
- Misses       4045     4719     +674     
- Partials      924      958      +34     

see 38 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 69.72% <ø> (-3.49%) ⬇️
mongodb 5.48% <ø> (-0.02%) ⬇️
pg 59.73% <ø> (-6.73%) ⬇️
shard-1 56.93% <ø> (-0.07%) ⬇️
shard-2 55.09% <ø> (-0.01%) ⬇️
shard-3 36.37% <ø> (-20.86%) ⬇️
sqlite 46.42% <ø> (-0.13%) ⬇️
unit 24.05% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit 2f80b0f into FerretDB:main Jul 20, 2023
23 of 27 checks passed
@AlekSi AlekSi deleted the commonerrors branch July 20, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants