Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make findAndModify integration tests pass for SQLite #3173

Merged
merged 4 commits into from Aug 10, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 8, 2023

Description

  • findandmodify_compat_test.go

Closes #3131.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #3173 (b93a4af) into main (f00c4d7) will decrease coverage by 28.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3173       +/-   ##
===========================================
- Coverage   75.53%   47.45%   -28.08%     
===========================================
  Files         396      396               
  Lines       22202    22202               
===========================================
- Hits        16771    10537     -6234     
- Misses       4452    10860     +6408     
+ Partials      979      805      -174     

see 126 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 37.96% <ø> (-33.98%) ⬇️
mongodb 5.30% <ø> (ø)
pg ?
shard-1 29.20% <ø> (-26.36%) ⬇️
shard-2 31.94% <ø> (-23.00%) ⬇️
shard-3 31.62% <ø> (-25.16%) ⬇️
sqlite 37.72% <ø> (-0.42%) ⬇️
unit 24.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup changed the title Sqlite tests findandmodify 3131 Make findAndModify integration tests pass for SQLite Aug 9, 2023
@noisersup noisersup marked this pull request as ready for review August 9, 2023 21:13
@noisersup noisersup requested a review from a team as a code owner August 9, 2023 21:13
@noisersup noisersup enabled auto-merge (squash) August 9, 2023 21:13
@noisersup noisersup added the code/chore Code maintenance improvements label Aug 9, 2023
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@noisersup noisersup merged commit 46897b4 into FerretDB:main Aug 10, 2023
23 of 27 checks passed
@noisersup noisersup deleted the sqlite-tests-findandmodify-3131 branch August 10, 2023 07:38
@AlekSi AlekSi added this to the v1.8.0 milestone Aug 14, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make all integration tests "pass" with SQLite
4 participants