Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Jaeger exporter #3368

Merged
merged 25 commits into from Sep 18, 2023

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Sep 15, 2023

Description

Closes #3341.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #3368 (b5f52b8) into main (58772a7) will decrease coverage by 1.28%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3368      +/-   ##
==========================================
- Coverage   74.10%   72.82%   -1.28%     
==========================================
  Files         413      413              
  Lines       25317    25317              
==========================================
- Hits        18760    18437     -323     
- Misses       5468     5757     +289     
- Partials     1089     1123      +34     
Files Changed Coverage
integration/setup/startup.go 87.50%
Flag Coverage Δ
integration 69.82% <87.50%> (-1.33%) ⬇️
mongodb-1 4.72% <87.50%> (ø)
pg-1 43.81% <87.50%> (ø)
pg-2 43.54% <87.50%> (ø)
pg-3 43.99% <87.50%> (ø)
sqlite-1 42.60% <87.50%> (-0.06%) ⬇️
sqlite-2 42.11% <87.50%> (ø)
sqlite-3 ?
unit 23.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 15, 2023
@AlekSi AlekSi added this to the Next milestone Sep 15, 2023
docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried everything locally, and the changes look good to me!
Thanks a lot for contributing!

@rumyantseva rumyantseva enabled auto-merge (squash) September 17, 2023 21:28
@AlekSi
Copy link
Member

AlekSi commented Sep 18, 2023

Thank you!

@rumyantseva rumyantseva merged commit 1cdf743 into FerretDB:main Sep 18, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace deprecated go.opentelemetry.io/otel/exporters/jaeger
3 participants