Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small tweaks #3377

Merged
merged 3 commits into from Sep 20, 2023
Merged

Add small tweaks #3377

merged 3 commits into from Sep 20, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 19, 2023

Description

Use %q for quoting.
Add labels.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Use `%q` for quoting. Add labels.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 19, 2023
@AlekSi AlekSi added this to the Next milestone Sep 19, 2023
@AlekSi AlekSi self-assigned this Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #3377 (3b6c8ee) into main (8425016) will decrease coverage by 1.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
- Coverage   74.08%   73.04%   -1.04%     
==========================================
  Files         414      414              
  Lines       25330    25330              
==========================================
- Hits        18766    18503     -263     
- Misses       5464     5695     +231     
- Partials     1100     1132      +32     
Files Changed Coverage
internal/handlers/pg/msg_createindexes.go 100.00%
internal/handlers/sqlite/msg_createindexes.go 100.00%
Flag Coverage Δ
integration 69.85% <100.00%> (-1.19%) ⬇️
mongodb-1 4.72% <0.00%> (ø)
pg-1 43.75% <33.33%> (+0.03%) ⬆️
pg-2 43.48% <33.33%> (ø)
pg-3 44.03% <0.00%> (+0.11%) ⬆️
sqlite-1 42.71% <33.33%> (+0.10%) ⬆️
sqlite-2 42.11% <33.33%> (ø)
sqlite-3 ?
unit 23.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review September 20, 2023 05:21
@AlekSi AlekSi requested a review from a team as a code owner September 20, 2023 05:21
@AlekSi AlekSi enabled auto-merge (squash) September 20, 2023 05:21
@AlekSi AlekSi requested review from a team and noisersup September 20, 2023 05:22
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 8a2a098 into FerretDB:main Sep 20, 2023
26 of 27 checks passed
@AlekSi AlekSi deleted the small-tweaks branch September 20, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants