Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RecordID to types.Document #3495

Merged
merged 2 commits into from Oct 5, 2023
Merged

Add RecordID to types.Document #3495

merged 2 commits into from Oct 5, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 4, 2023

Description

Refs #3458.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 4, 2023
@AlekSi AlekSi added this to the Next milestone Oct 4, 2023
@AlekSi AlekSi requested a review from a team as a code owner October 4, 2023 13:47
@AlekSi AlekSi self-assigned this Oct 4, 2023
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team and noisersup October 4, 2023 13:47
@AlekSi AlekSi enabled auto-merge (squash) October 4, 2023 13:47
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #3495 (df6c1f2) into main (f9f5e9a) will decrease coverage by 1.36%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3495      +/-   ##
==========================================
- Coverage   74.49%   73.13%   -1.36%     
==========================================
  Files         424      424              
  Lines       26539    26548       +9     
==========================================
- Hits        19770    19416     -354     
- Misses       5632     5951     +319     
- Partials     1137     1181      +44     
Files Coverage Δ
internal/handlers/sjson/sjson.go 85.65% <ø> (ø)
internal/types/object_id.go 91.30% <100.00%> (ø)
internal/types/timestamp.go 100.00% <100.00%> (ø)
internal/types/types.go 94.11% <100.00%> (+0.08%) ⬆️
internal/types/document.go 90.29% <0.00%> (-1.56%) ⬇️

... and 33 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.79% <27.27%> (-1.57%) ⬇️
hana-1 ?
integration 67.79% <27.27%> (-1.61%) ⬇️
mongodb-1 4.60% <0.00%> (-0.01%) ⬇️
pg-1 ?
pg-2 42.90% <27.27%> (-0.56%) ⬇️
pg-3 42.64% <18.18%> (-0.64%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ?
postgresql-3 ?
sort-false 67.79% <27.27%> (-1.18%) ⬇️
sort-true ?
sqlite-1 39.47% <27.27%> (-0.09%) ⬇️
sqlite-2 42.21% <27.27%> (-0.03%) ⬇️
sqlite-3 42.14% <18.18%> (-0.09%) ⬇️
unit 25.18% <63.63%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

internal/types/document.go Show resolved Hide resolved
@AlekSi AlekSi requested a review from noisersup October 5, 2023 06:03
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi merged commit 0a56f5b into FerretDB:main Oct 5, 2023
25 of 29 checks passed
@AlekSi AlekSi deleted the record-id branch October 5, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants