Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in contributing documentation #3507

Merged
merged 6 commits into from Oct 6, 2023

Conversation

jrmanes
Copy link
Contributor

@jrmanes jrmanes commented Oct 5, 2023

Description

Hello team!

Following the CONTRIBUTING.md, I tried to ran task build-release but looks like this command doesn't exists anymore, and should be build-production.

Cheers!

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@jrmanes jrmanes requested a review from AlekSi as a code owner October 5, 2023 19:02
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@mergify mergify bot assigned jrmanes Oct 5, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
@AlekSi AlekSi added this to the Next milestone Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #3507 (60c9887) into main (bfa7300) will increase coverage by 4.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3507      +/-   ##
==========================================
+ Coverage   69.38%   74.04%   +4.65%     
==========================================
  Files         420      426       +6     
  Lines       26645    26963     +318     
==========================================
+ Hits        18488    19965    +1477     
+ Misses       6909     5793    -1116     
+ Partials     1248     1205      -43     

see 110 files with indirect coverage changes

Flag Coverage Δ
filter-true 70.67% <ø> (+1.29%) ⬆️
integration 70.67% <ø> (+1.29%) ⬆️
mongodb-1 4.53% <ø> (ø)
pg-1 39.20% <ø> (ø)
pg-2 42.28% <ø> (-0.04%) ⬇️
pg-3 42.73% <ø> (ø)
postgresql-1 11.06% <ø> (-6.22%) ⬇️
postgresql-2 15.87% <ø> (+0.27%) ⬆️
postgresql-3 18.79% <ø> (-1.29%) ⬇️
sort-false 70.67% <ø> (+1.29%) ⬆️
sqlite-1 38.34% <ø> (-0.04%) ⬇️
sqlite-2 41.42% <ø> (?)
sqlite-3 42.11% <ø> (+<0.01%) ⬆️
unit 25.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jrmanes jrmanes requested a review from AlekSi October 6, 2023 12:06
@AlekSi AlekSi changed the title fix: typo in task name Fix typo in contributing documentation Oct 6, 2023
@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label Oct 6, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 6, 2023 14:05
@AlekSi
Copy link
Member

AlekSi commented Oct 6, 2023

Thank you!

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@AlekSi AlekSi merged commit 4002677 into FerretDB:main Oct 6, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants