Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handler accept constructed backend #3710

Merged
merged 8 commits into from Nov 15, 2023

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Nov 14, 2023

Description

Closes #3662.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #3710 (fb857bc) into main (6c5c709) will decrease coverage by 0.17%.
The diff coverage is 50.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3710      +/-   ##
==========================================
- Coverage   76.33%   76.16%   -0.17%     
==========================================
  Files         323      323              
  Lines       23034    23043       +9     
==========================================
- Hits        17582    17550      -32     
- Misses       4412     4450      +38     
- Partials     1040     1043       +3     
Files Coverage Δ
ferretdb/ferretdb.go 83.16% <100.00%> (+0.51%) ⬆️
integration/setup/listener.go 74.11% <100.00%> (-2.67%) ⬇️
internal/handlers/sqlite/sqlite.go 68.42% <100.00%> (-13.81%) ⬇️
internal/handlers/registry/registry.go 43.47% <33.33%> (ø)
internal/handlers/registry/postgresql.go 77.77% <62.50%> (-22.23%) ⬇️
internal/handlers/registry/sqlite.go 77.77% <62.50%> (-22.23%) ⬇️
internal/handlers/registry/hana.go 3.44% <0.00%> (-96.56%) ⬇️

... and 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.19% <40.98%> (-0.19%) ⬇️
hana-1 ?
integration 72.19% <40.98%> (-0.19%) ⬇️
mongodb-1 5.46% <0.00%> (-0.01%) ⬇️
postgresql-1 52.31% <24.59%> (-0.06%) ⬇️
postgresql-2 51.59% <24.59%> (-0.07%) ⬇️
postgresql-3 50.67% <24.59%> (-0.05%) ⬇️
sort-false 72.19% <40.98%> (-0.19%) ⬇️
sqlite-1 51.58% <24.59%> (-0.05%) ⬇️
sqlite-2 50.84% <24.59%> (-0.01%) ⬇️
sqlite-3 49.84% <24.59%> (-0.05%) ⬇️
unit 30.09% <31.03%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Nov 15, 2023
@rumyantseva rumyantseva added this to the Next milestone Nov 15, 2023
@rumyantseva rumyantseva requested review from a team and noisersup November 15, 2023 15:51
@rumyantseva rumyantseva marked this pull request as ready for review November 15, 2023 15:51
@rumyantseva rumyantseva requested review from a team and AlekSi as code owners November 15, 2023 15:51
@rumyantseva rumyantseva enabled auto-merge (squash) November 15, 2023 15:51
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rumyantseva rumyantseva merged commit 07a145f into FerretDB:main Nov 15, 2023
27 of 28 checks passed
@rumyantseva rumyantseva deleted the issue-3662-handler branch November 15, 2023 17:52
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move and rename the handler
3 participants