Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startup warning for debug builds #3735

Merged
merged 4 commits into from Nov 23, 2023
Merged

Add startup warning for debug builds #3735

merged 4 commits into from Nov 23, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 22, 2023

Description

To make things a bit more clear.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #3735 (400c7c3) into main (7936b3a) will decrease coverage by 5.69%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3735      +/-   ##
==========================================
- Coverage   76.52%   70.84%   -5.69%     
==========================================
  Files         324      324              
  Lines       23087    23090       +3     
==========================================
- Hits        17667    16357    -1310     
- Misses       4385     5634    +1249     
- Partials     1035     1099      +64     
Files Coverage Δ
internal/handlers/sqlite/msg_getlog.go 0.00% <0.00%> (-81.66%) ⬇️

... and 57 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.40% <0.00%> (-6.17%) ⬇️
hana-1 ?
integration 66.40% <0.00%> (-6.17%) ⬇️
mongodb-1 5.48% <0.00%> (-0.01%) ⬇️
postgresql-1 51.81% <0.00%> (-0.01%) ⬇️
postgresql-2 51.45% <0.00%> (-0.01%) ⬇️
postgresql-3 ?
sqlite-1 51.01% <0.00%> (+0.08%) ⬆️
sqlite-2 50.61% <0.00%> (-0.01%) ⬇️
sqlite-3 ?
unit 30.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Nov 22, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 22, 2023
@AlekSi AlekSi marked this pull request as ready for review November 22, 2023 09:29
@AlekSi AlekSi requested a review from a team as a code owner November 22, 2023 09:29
@AlekSi AlekSi enabled auto-merge (squash) November 22, 2023 09:29
@AlekSi AlekSi requested review from a team and noisersup November 23, 2023 03:20
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit aa05f0f into FerretDB:main Nov 23, 2023
25 of 27 checks passed
@AlekSi AlekSi deleted the warning branch November 23, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants