Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL backend registry #3850

Merged
merged 17 commits into from Dec 19, 2023
Merged

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Dec 13, 2023

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added this to the Next milestone Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #3850 (751dddf) into main (cd22960) will decrease coverage by 0.81%.
The diff coverage is 44.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3850      +/-   ##
==========================================
- Coverage   76.20%   75.39%   -0.81%     
==========================================
  Files         317      323       +6     
  Lines       24027    24625     +598     
==========================================
+ Hits        18309    18567     +258     
- Misses       4655     4964     +309     
- Partials     1063     1094      +31     
Files Coverage Δ
internal/backends/mysql/metadata/pool/uri.go 76.00% <100.00%> (ø)
internal/util/testutil/mysql.go 83.33% <100.00%> (+83.33%) ⬆️
internal/backends/mysql/metadata/metadata.go 0.00% <0.00%> (ø)
internal/backends/mysql/metadata/indexes.go 0.00% <0.00%> (ø)
internal/backends/mysql/metadata/pool/pool.go 57.29% <48.27%> (ø)
internal/backends/mysql/metadata/registry.go 47.66% <47.66%> (ø)

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.28% <0.00%> (-0.22%) ⬇️
hana-1 ?
integration 72.28% <0.00%> (-0.22%) ⬇️
mongodb-1 5.27% <0.00%> (ø)
postgresql-1 52.23% <0.00%> (-0.02%) ⬇️
postgresql-2 50.77% <0.00%> (+0.06%) ⬆️
postgresql-3 53.46% <0.00%> (ø)
sqlite-1 51.48% <0.00%> (-0.02%) ⬇️
sqlite-2 49.78% <0.00%> (ø)
sqlite-3 ?
unit 30.89% <44.91%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@adetunjii adetunjii requested a review from a team as a code owner December 13, 2023 23:37
@AlekSi AlekSi enabled auto-merge (squash) December 14, 2023 19:21
@AlekSi AlekSi self-requested a review December 14, 2023 19:22
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 14, 2023
@AlekSi AlekSi requested review from a team, henvic and noisersup December 14, 2023 19:23
henvic
henvic previously approved these changes Dec 14, 2023
AlekSi

This comment was marked as duplicate.

@AlekSi AlekSi self-requested a review December 15, 2023 05:55
AlekSi

This comment was marked as duplicate.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails

auto-merge was automatically disabled December 15, 2023 08:29

Head branch was pushed to by a user without write access

@AlekSi AlekSi requested a review from a team December 15, 2023 09:16
@AlekSi AlekSi modified the milestones: v1.17.0, Next Dec 18, 2023
@AlekSi AlekSi enabled auto-merge (squash) December 19, 2023 14:22
@AlekSi AlekSi merged commit 8a32949 into FerretDB:main Dec 19, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants