Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #3871

Merged
merged 4 commits into from Dec 19, 2023
Merged

Fix tests #3871

merged 4 commits into from Dec 19, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 18, 2023

Description

Previous tests might create capped collections in other databases.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Previous tests might create capped collections in other databases.
@AlekSi AlekSi self-assigned this Dec 18, 2023
@AlekSi AlekSi added this to the Next milestone Dec 18, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 18, 2023
@AlekSi AlekSi marked this pull request as ready for review December 18, 2023 11:29
@AlekSi AlekSi requested a review from a team as a code owner December 18, 2023 11:29
@AlekSi AlekSi enabled auto-merge (squash) December 18, 2023 11:30
@AlekSi AlekSi disabled auto-merge December 18, 2023 11:30
@AlekSi AlekSi enabled auto-merge (squash) December 18, 2023 11:30
@AlekSi AlekSi requested review from a team, henvic and noisersup December 18, 2023 11:30
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #3871 (0942d4a) into main (23714a4) will decrease coverage by 6.51%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3871      +/-   ##
==========================================
- Coverage   76.16%   69.65%   -6.51%     
==========================================
  Files         317      317              
  Lines       24027    24027              
==========================================
- Hits        18300    16737    -1563     
- Misses       4663     6159    +1496     
- Partials     1064     1131      +67     

see 72 files with indirect coverage changes

Flag Coverage Δ
filter-true 65.01% <ø> (-7.45%) ⬇️
hana-1 ?
integration 65.01% <ø> (-7.45%) ⬇️
mongodb-1 5.27% <ø> (ø)
postgresql-1 52.23% <ø> (-0.02%) ⬇️
postgresql-2 50.76% <ø> (+0.05%) ⬆️
postgresql-3 ?
sqlite-1 51.48% <ø> (ø)
sqlite-2 ?
sqlite-3 ?
unit 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 5ae90d4 into FerretDB:main Dec 19, 2023
26 of 27 checks passed
@AlekSi AlekSi deleted the fix-tests branch December 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants