Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement usersInfo command #3897

Merged
merged 57 commits into from Jan 4, 2024
Merged

Implement usersInfo command #3897

merged 57 commits into from Jan 4, 2024

Conversation

henvic
Copy link
Contributor

@henvic henvic commented Dec 21, 2023 •
edited

Description

Implement usersInfo command.

Closes #1497

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@henvic henvic added the code/feature Some user-visible feature is not implemented yet label Dec 21, 2023
@henvic henvic added this to the Next milestone Dec 21, 2023
@henvic henvic requested a review from a team December 21, 2023 09:18
@henvic henvic requested review from AlekSi and removed request for AlekSi January 3, 2024 15:10
@henvic
Copy link
Contributor Author

henvic commented Jan 3, 2024

Needs review from @AlekSi to trigger auto-merge due to /website/ update.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@henvic this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jan 4, 2024
@henvic henvic dismissed stale reviews from noisersup and rumyantseva via 039f3cb January 4, 2024 10:18
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jan 4, 2024
@AlekSi AlekSi requested review from noisersup, rumyantseva and a team January 4, 2024 13:12
rumyantseva
rumyantseva reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I don't see any changes, I guess the only change is the conflict resolved)

rumyantseva
rumyantseva previously approved these changes Jan 4, 2024
View reviewed changes
AlekSi
AlekSi reviewed Jan 4, 2024
View reviewed changes
integration/users/usersinfo_test.go Outdated Show resolved Hide resolved
integration/users/usersinfo_test.go Outdated Show resolved Hide resolved
integration/users/usersinfo_test.go Outdated Show resolved Hide resolved
integration/users/usersinfo_test.go Outdated Show resolved Hide resolved
@henvic
Copy link
Contributor Author

henvic commented Jan 4, 2024

@AlekSi, I've just addressed the comments!

@AlekSi AlekSi requested review from a team January 4, 2024 16:15
@henvic henvic merged commit 74d7272 into FerretDB:main Jan 4, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup noisersup approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@henvic henvic

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

Implement usersInfo command
4 participants
@henvic @AlekSi @rumyantseva @noisersup