Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AssertEqual helper handle duplicate keys #3911

Merged
merged 2 commits into from Dec 27, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 27, 2023

Description

*types.Document.Get panics in that case.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 27, 2023
@AlekSi AlekSi added this to the Next milestone Dec 27, 2023
@AlekSi AlekSi self-assigned this Dec 27, 2023
@AlekSi AlekSi marked this pull request as ready for review December 27, 2023 16:39
@AlekSi AlekSi requested a review from a team as a code owner December 27, 2023 16:39
@AlekSi AlekSi enabled auto-merge (squash) December 27, 2023 16:39
@AlekSi AlekSi requested review from a team, henvic and noisersup December 27, 2023 16:39
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (af36e33) 74.92% compared to head (8b97cb8) 68.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3911      +/-   ##
==========================================
- Coverage   74.92%   68.11%   -6.81%     
==========================================
  Files         330      330              
  Lines       25595    25598       +3     
==========================================
- Hits        19177    17437    -1740     
- Misses       5257     6952    +1695     
- Partials     1161     1209      +48     
Files Coverage Δ
internal/util/testutil/equal.go 50.90% <70.00%> (-0.70%) ⬇️

... and 73 files with indirect coverage changes

Flag Coverage Δ
filter-true 64.06% <60.00%> (-7.85%) ⬇️
hana-1 ?
integration 64.06% <60.00%> (-7.85%) ⬇️
mongodb-1 5.22% <60.00%> (+0.14%) ⬆️
postgresql-1 50.99% <60.00%> (-0.01%) ⬇️
postgresql-2 49.65% <60.00%> (+0.02%) ⬆️
postgresql-3 ?
sqlite-1 50.17% <60.00%> (-0.06%) ⬇️
sqlite-2 48.65% <60.00%> (-0.01%) ⬇️
sqlite-3 ?
unit 30.83% <70.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AlekSi AlekSi merged commit 2c17e05 into FerretDB:main Dec 27, 2023
26 of 27 checks passed
@AlekSi AlekSi deleted the fix-comparision branch December 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants