Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement $bitsAllClear #394

Merged
merged 30 commits into from
Mar 25, 2022
Merged

Implement $bitsAllClear #394

merged 30 commits into from
Mar 25, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Mar 24, 2022 •
edited by AlekSi
Loading

Refs #256.

@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #394 (51e2c2c) into main (4fd1075) will increase coverage by 0.13%.
The diff coverage is 53.19%.

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   49.61%   49.75%   +0.13%     
==========================================
  Files         113      114       +1     
  Lines        5524     5658     +134     
==========================================
+ Hits         2741     2815      +74     
- Misses       2340     2393      +53     
- Partials      443      450       +7
Impacted Files Coverage Δ
internal/handlers/common/error.go 65.62% <ø> (ø)
internal/handlers/common/errorcode_string.go 45.83% <33.33%> (+4.92%) ⬆️
internal/handlers/common/params.go 50.79% <42.50%> (-14.43%) ⬇️
internal/types/binary.go 70.00% <70.00%> (ø)
internal/handlers/common/filter.go 83.85% <77.27%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd1075...51e2c2c. Read the comment docs.

@w84thesun w84thesun marked this pull request as ready for review March 24, 2022 13:51
@w84thesun w84thesun requested a review from AlekSi as a code owner March 24, 2022 13:51
@w84thesun w84thesun added the trust PRs that can access Actions secrets label Mar 24, 2022
@w84thesun w84thesun self-assigned this Mar 24, 2022
@AlekSi
Copy link
Member

AlekSi commented Mar 24, 2022

That PR handles only $bitsAllClear, right? Why it closes #256?

@AlekSi AlekSi changed the title Issue 256 bitwise operators Implement $bitsAllClear Mar 24, 2022
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Mar 24, 2022
@AlekSi AlekSi added this to the v0.0.7 milestone Mar 24, 2022
AlekSi
AlekSi reviewed Mar 24, 2022
View reviewed changes
internal/handlers/common/error.go Outdated Show resolved Hide resolved
internal/handlers/common/params.go Outdated Show resolved Hide resolved
internal/handlers/common/params.go Outdated Show resolved Hide resolved
internal/handlers/common/params.go Outdated Show resolved Hide resolved
internal/types/binary.go Outdated Show resolved Hide resolved
@w84thesun w84thesun requested a review from AlekSi March 25, 2022 07:35
AlekSi
AlekSi reviewed Mar 25, 2022
View reviewed changes
internal/handlers/common/params.go Outdated Show resolved Hide resolved
internal/types/binary_test.go Show resolved Hide resolved
@w84thesun w84thesun requested a review from AlekSi March 25, 2022 08:46
@w84thesun w84thesun requested a review from AlekSi March 25, 2022 09:07
AlekSi
AlekSi previously approved these changes Mar 25, 2022
View reviewed changes
@AlekSi
Copy link
Member

AlekSi commented Mar 25, 2022

@w84thesun why you self-assigned that PR?

@w84thesun w84thesun assigned w84thesun and unassigned w84thesun Mar 25, 2022
@w84thesun w84thesun requested a review from AlekSi March 25, 2022 16:23
@AlekSi AlekSi merged commit 5361743 into FerretDB:main Mar 25, 2022
@w84thesun w84thesun deleted the issue-256-bitwise-operators branch March 25, 2022 16:49
@w84thesun w84thesun mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@seeforschauer seeforschauer Awaiting requested review from seeforschauer

Assignees

@w84thesun w84thesun

Labels
code/feature Some user-visible feature is not implemented yet trust PRs that can access Actions secrets
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w84thesun @AlekSi