Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all bitwise query operators #400

Merged
merged 15 commits into from
Mar 30, 2022
Merged

Support all bitwise query operators #400

merged 15 commits into from
Mar 30, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Mar 25, 2022 •
edited by AlekSi

Closes #256.

@w84thesun w84thesun changed the title WIP Implement bitwise operators Mar 25, 2022
@w84thesun w84thesun added trust PRs that can access Actions secrets code/feature Some user-visible feature is not implemented yet labels Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited

Codecov Report

Merging #400 (a10846e) into main (ccc7146) will increase coverage by 0.41%.
The diff coverage is 79.34%.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   51.67%   52.09%   +0.41%     
==========================================
  Files         113      113              
  Lines        5790     5861      +71     
==========================================
+ Hits         2992     3053      +61     
- Misses       2324     2328       +4     
- Partials      474      480       +6
Impacted Files Coverage Δ
internal/handlers/common/params.go 53.48% <75.00%> (+2.69%) ⬆️
internal/handlers/common/filter.go 83.27% <76.78%> (-0.77%) ⬇️
internal/handlers/common/error.go 75.00% <90.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc7146...a10846e. Read the comment docs.

@w84thesun
Copy link
Contributor Author

In order to tests pass I need this PR to be merged → AlekSi/test_db#12

@w84thesun w84thesun marked this pull request as ready for review March 29, 2022 16:03
@w84thesun w84thesun requested a review from AlekSi as a code owner March 29, 2022 16:03
@AlekSi AlekSi added this to the v0.0.7 milestone Mar 29, 2022
AlekSi
AlekSi reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail

@w84thesun w84thesun requested a review from AlekSi March 30, 2022 11:36
AlekSi
AlekSi reviewed Mar 30, 2022
View reviewed changes
internal/handlers/common/error.go Outdated Show resolved Hide resolved
internal/handlers/common/error.go Outdated Show resolved Hide resolved
internal/handlers/common/params.go Show resolved Hide resolved
internal/handlers/handler_test.go Outdated Show resolved Hide resolved
@AlekSi
Update internal/handlers/common/error.go
1a5d349 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
seeforschauer
seeforschauer suggested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@seeforschauer seeforschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail

internal/handlers/common/params.go Outdated Show resolved Hide resolved
@w84thesun w84thesun requested a review from AlekSi March 30, 2022 13:04
@AlekSi AlekSi changed the title Implement bitwise operators Implement all bitwise operators Mar 30, 2022
@AlekSi AlekSi changed the title Implement all bitwise operators Support all bitwise query operators Mar 30, 2022
@AlekSi AlekSi merged commit 85f030b into FerretDB:main Mar 30, 2022
@w84thesun w84thesun deleted the implement-bitwise-operators branch March 30, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@seeforschauer seeforschauer Awaiting requested review from seeforschauer

Assignees
No one assigned
Labels
code/feature Some user-visible feature is not implemented yet trust PRs that can access Actions secrets
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Support all bitwise query operators
3 participants
@w84thesun @AlekSi @seeforschauer