Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental SCRAM-SHA-1/SCRAM-SHA-256 authentication support #4078

Merged
merged 96 commits into from Feb 19, 2024
Merged

Add experimental SCRAM-SHA-1/SCRAM-SHA-256 authentication support #4078

merged 96 commits into from Feb 19, 2024

Conversation

henvic
Copy link
Contributor

@henvic henvic commented Feb 15, 2024 •
edited

Closes #2012.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@henvic henvic enabled auto-merge (squash) February 15, 2024 01:59
@henvic henvic requested review from a team, chilagrow and noisersup February 15, 2024 01:59
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 15, 2024

@henvic this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Feb 15, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Feb 16, 2024
chilagrow
chilagrow reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments 🤗 great work

internal/util/password/scram.go Outdated Show resolved Hide resolved
internal/util/password/scramsha256_test.go Outdated Show resolved Hide resolved
integration/users/connection_test.go Show resolved Hide resolved
henvic and others added 3 commits February 16, 2024 09:28
@henvic @chilagrow
Update internal/util/password/scram.go
ca537ec 
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@henvic @chilagrow
Apply suggestions from code review
0149a7a 
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@henvic
wip
b7c242f
@henvic henvic requested a review from a team February 19, 2024 09:17
@AlekSi AlekSi modified the milestones: v1.20.0, Next Feb 19, 2024
rumyantseva
rumyantseva approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and the tests look reasonable to me!

@henvic henvic merged commit 47819e2 into FerretDB:main Feb 19, 2024
26 of 27 checks passed
@AlekSi AlekSi changed the title Add SCRAM-SHA-1 authentication support Add experimental SCRAM-SHA-1 authentication support Mar 19, 2024
@AlekSi AlekSi changed the title Add experimental SCRAM-SHA-1 authentication support Add experimental SCRAM-SHA-1/SCRAM-SHA-256 authentication support Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@henvic henvic

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.

Support SCRAM-SHA-1 authentication mechanism
6 participants
@henvic @rumyantseva @chilagrow @AlekSi @Fashander @adetunjii