Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise SCRAM / SASL support in addition to PLAIN #4113

Merged
merged 34 commits into from
Mar 7, 2024

wip

2c834b4
Select commit
Loading
Failed to load commit list.
Merged

Advertise SCRAM / SASL support in addition to PLAIN #4113

wip
2c834b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 26, 2024 in 1s

75.05% (-1.15%) compared to 81e0be8

View this Pull Request on Codecov

75.05% (-1.15%) compared to 81e0be8

Details

Codecov Report

Attention: Patch coverage is 69.56522% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 75.05%. Comparing base (81e0be8) to head (2c834b4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4113      +/-   ##
==========================================
- Coverage   76.19%   75.05%   -1.15%     
==========================================
  Files         349      349              
  Lines       22170    22221      +51     
==========================================
- Hits        16893    16678     -215     
- Misses       3965     4266     +301     
+ Partials     1312     1277      -35     
Files Coverage Δ
internal/handler/msg_getparameter.go 93.42% <100.00%> (ø)
internal/handler/msg_usersinfo.go 76.72% <100.00%> (ø)
internal/handler/msg_hello.go 68.49% <67.69%> (-22.42%) ⬇️

... and 12 files with indirect coverage changes