Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FERRETDB_USERNAME stub #4374

Closed
wants to merge 1 commit into from
Closed

Conversation

noisersup
Copy link
Member

Description

Closes #4245.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (6e3f7b2) to head (fb05ef2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4374      +/-   ##
==========================================
- Coverage   74.80%   74.06%   -0.74%     
==========================================
  Files         326      326              
  Lines       22471    22471              
==========================================
- Hits        16809    16643     -166     
- Misses       4429     4617     +188     
+ Partials     1233     1211      -22     

see 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.42% <ø> (-0.83%) ⬇️
hana-1 ?
integration 67.42% <ø> (-0.83%) ⬇️
mongodb-1 5.09% <ø> (-0.01%) ⬇️
postgresql-1 44.71% <ø> (+0.09%) ⬆️
postgresql-2 44.79% <ø> (+0.01%) ⬆️
postgresql-3 41.44% <ø> (ø)
postgresql-4 41.07% <ø> (+<0.01%) ⬆️
postgresql-5 43.25% <ø> (ø)
sqlite-1 43.72% <ø> (ø)
sqlite-2 44.12% <ø> (-0.03%) ⬇️
sqlite-3 40.69% <ø> (ø)
sqlite-4 40.42% <ø> (-0.03%) ⬇️
sqlite-5 42.38% <ø> (ø)
unit 33.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think FERRETDB_SETUP_USERNAME is already handled by FerretDB via the usual Kong CLI

@noisersup
Copy link
Member Author

I think FERRETDB_SETUP_USERNAME is already handled by FerretDB via the usual Kong CLI

@AlekSi What's the goal of this issue then? It's possible to set setup username in docker already.

@AlekSi
Copy link
Member

AlekSi commented Jun 20, 2024

We should check that it works

@noisersup
Copy link
Member Author

It works, I've already checked that while working on #4246. Should I write unit test for that?

@AlekSi
Copy link
Member

AlekSi commented Jun 20, 2024

No, I don't think there is a need for it

@AlekSi AlekSi closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Implement FERRETDB_USERNAME and FERRETDB_PASSWORD for Docker images
2 participants