Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $slice projection query operator #518

Merged
merged 49 commits into from
May 10, 2022
Merged

Support $slice projection query operator #518

merged 49 commits into from
May 10, 2022

Conversation

gevorgyg
Copy link
Contributor

Closes #362.

@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #518 (a8ec01e) into main (98747f0) will increase coverage by 0.58%.
The diff coverage is 74.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   61.03%   61.62%   +0.58%     
==========================================
  Files         121      121              
  Lines        6650     6785     +135     
==========================================
+ Hits         4059     4181     +122     
- Misses       2081     2086       +5     
- Partials      510      518       +8
Impacted Files Coverage Δ
internal/handlers/common/error.go 80.70% <ø> (ø)
internal/handlers/common/errorcode_string.go 80.00% <66.66%> (+22.30%) ⬆️
internal/handlers/common/projection.go 63.75% <74.57%> (+19.96%) ⬆️
internal/handlers/pg/msg_find.go 66.35% <0.00%> (+2.80%) ⬆️
Flag Coverage Δ
FerretDB 55.27% <74.44%> (+0.76%) ⬆️
MongoDB 6.56% <0.00%> (-0.14%) ⬇️
integration 55.30% <74.44%> (+0.71%) ⬆️
unit 26.43% <0.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v0.2.0 milestone Apr 25, 2022
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Apr 25, 2022
@gevorgyg gevorgyg changed the title Support $slice projection query operator [WIP] Support $slice projection query operator May 1, 2022
seeforschauer
seeforschauer reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@seeforschauer seeforschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💟

internal/types/types.go Outdated Show resolved Hide resolved
internal/types/types.go Outdated Show resolved Hide resolved
internal/types/types.go Outdated Show resolved Hide resolved
internal/types/types.go Outdated Show resolved Hide resolved
@gevorgyg
Copy link
Contributor Author

gevorgyg commented May 6, 2022

@seeforschauer to be honest, I feel a bit overwhelmed by the scope of this PR, I'm afraid it may never end 😅
WDYT about calling it a day and addressing the work that needs to be done on JSONSyntax in a separate issue?
For now I've added placeholders for unsupported types and sorted everything in the correct order

@seeforschauer
Copy link
Contributor

@GinGin3203 let it be a day :-) I fully understand this :) Some of my own PRs are also very big.

AlekSi
AlekSi requested changes May 6, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and addressing the work that needs to be done on JSONSyntax in a separate issue?

Let's drop JSONSyntax completely. See #518 (comment)

seeforschauer
seeforschauer previously approved these changes May 9, 2022
View reviewed changes
@gevorgyg
Copy link
Contributor Author

gevorgyg commented May 9, 2022

@AlekSi as I understand, this PR can be merged?

@AlekSi
Copy link
Member

AlekSi commented May 9, 2022

I will take a look ASAP

@AlekSi AlekSi enabled auto-merge (squash) May 10, 2022 07:42
AlekSi
AlekSi requested changes May 10, 2022
View reviewed changes
integration/query_projection_test.go Outdated Show resolved Hide resolved
integration/query_projection_test.go Outdated Show resolved Hide resolved
integration/query_projection_test.go Show resolved Hide resolved
integration/query_projection_test.go Outdated Show resolved Hide resolved
internal/handlers/common/projection.go Outdated Show resolved Hide resolved
internal/handlers/common/projection.go Outdated Show resolved Hide resolved
internal/handlers/common/projection.go Outdated Show resolved Hide resolved
internal/handlers/common/projection.go Show resolved Hide resolved
auto-merge was automatically disabled May 10, 2022 12:24

Head branch was pushed to by a user without write access

@seeforschauer seeforschauer self-requested a review May 10, 2022 12:29
@seeforschauer seeforschauer requested a review from AlekSi May 10, 2022 12:32
@AlekSi AlekSi enabled auto-merge (squash) May 10, 2022 12:43
@AlekSi AlekSi merged commit 2fe1f84 into FerretDB:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@seeforschauer seeforschauer seeforschauer approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@gevorgyg gevorgyg

Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.

Support $slice projection query operator
4 participants
@gevorgyg @AlekSi @seeforschauer @w84thesun