Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types.MustNewDocument in some places #579

Merged
merged 1 commit into from
May 10, 2022
Merged

Remove types.MustNewDocument in some places #579

merged 1 commit into from
May 10, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 10, 2022

No description provided.

@AlekSi AlekSi changed the title Remove types.MustNewDocument in some places Remove types.MustNewDocument in some places May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #579 (a0a7d58) into main (2fe1f84) will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   61.62%   61.62%           
=======================================
  Files         121      121           
  Lines        6785     6785           
=======================================
  Hits         4181     4181           
  Misses       2086     2086           
  Partials      518      518
Impacted Files Coverage Δ
internal/handlers/pg/msg_getcmdlineopts.go 0.00% <0.00%> (ø)
integration/helpers.go 91.50% <100.00%> (ø)
internal/fjson/document.go 52.63% <100.00%> (ø)
internal/handlers/pg/msg_dropdatabase.go 62.06% <100.00%> (ø)
internal/handlers/pg/msg_hostinfo.go 71.42% <100.00%> (ø)
internal/util/version/version.go 33.33% <100.00%> (ø)
internal/wire/op_msg.go 49.76% <100.00%> (ø)
Flag Coverage Δ
FerretDB 55.27% <85.71%> (ø)
MongoDB 6.53% <28.57%> (-0.03%) ⬇️
integration 55.30% <85.71%> (ø)
unit 26.43% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review May 10, 2022 13:52
@AlekSi AlekSi requested review from a team, w84thesun and seeforschauer and removed request for a team May 10, 2022 13:53
@AlekSi AlekSi self-assigned this May 10, 2022
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 10, 2022
@AlekSi AlekSi added this to the v0.2.1 milestone May 10, 2022
@AlekSi AlekSi enabled auto-merge (squash) May 10, 2022 13:53
seeforschauer
seeforschauer reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@seeforschauer seeforschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not everywhere?

@AlekSi
Copy link
Member Author

AlekSi commented May 10, 2022

For the next PR

@AlekSi AlekSi requested a review from seeforschauer May 10, 2022 13:56
@AlekSi AlekSi merged commit 758c924 into FerretDB:main May 10, 2022
@AlekSi AlekSi deleted the must branch May 10, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeforschauer seeforschauer seeforschauer approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @seeforschauer