-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make linter to enforce our preferred types order in type switch #654
Conversation
Codecov Report
@@ Coverage Diff @@
## main #654 +/- ##
==========================================
+ Coverage 62.42% 62.44% +0.02%
==========================================
Files 231 231
Lines 10885 10883 -2
==========================================
+ Hits 6795 6796 +1
+ Misses 3313 3308 -5
- Partials 777 779 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…es-527-linterSwitch
…es-527-linterSwitch
…es-527-linterSwitch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the tool into tools/check-switch.go, hook it into tools/tools.go, tools/go.mod
@fenogentov would you please fix linters? |
this is an example of how the new linter works |
…es-527-linterSwitch
…tDB into issues-527-linterSwitch
…itch' into issues-527-linterSwitch
# Conflicts: # internal/tjson/tjson_test.go
Thank you! and sorry for a huge delay |
Closes #527.