-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build tigris
handler only if tag is present
#681
Conversation
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 64.21% 64.22%
=======================================
Files 193 193
Lines 7814 7816 +2
=======================================
+ Hits 5018 5020 +2
Misses 2233 2233
Partials 563 563
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the reasons behind the init
coding choices (see my comments).
Building without it produces a much smaller binary.
2cae848
to
b4a7d6e
Compare
Co-authored-by: Elena Grahovac <elena@grahovac.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Elena Grahovac <elena@grahovac.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Building without it produces a much smaller binary.