Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tigris handler only if tag is present #681

Merged
merged 7 commits into from
Jun 7, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 1, 2022

Building without it produces a much smaller binary.

@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Jun 1, 2022
@AlekSi AlekSi added this to the v0.3.1 milestone Jun 1, 2022
@AlekSi AlekSi requested a review from a team June 1, 2022 19:27
@AlekSi AlekSi self-assigned this Jun 1, 2022
@AlekSi AlekSi requested a review from rumyantseva as a code owner June 1, 2022 19:27
@AlekSi AlekSi requested review from a team, w84thesun and seeforschauer and removed request for a team June 1, 2022 19:27
@AlekSi AlekSi enabled auto-merge (squash) June 1, 2022 19:28
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #681 (84877d2) into main (fb8b9d6) will increase coverage by 0.00%.
The diff coverage is 56.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   64.21%   64.22%           
=======================================
  Files         193      193           
  Lines        7814     7816    +2     
=======================================
+ Hits         5018     5020    +2     
  Misses       2233     2233           
  Partials      563      563           
Impacted Files Coverage Δ
internal/handlers/dummy/dummy.go 0.00% <0.00%> (ø)
internal/handlers/tigris/tigris.go 0.00% <0.00%> (ø)
internal/util/version/version.go 33.33% <57.14%> (ø)
integration/setup.go 83.84% <100.00%> (+0.12%) ⬆️
internal/handlers/pg/pg.go 80.00% <100.00%> (+2.22%) ⬆️
Flag Coverage Δ
FerretDB 60.38% <75.00%> (+0.01%) ⬆️
MongoDB 7.46% <33.33%> (-0.01%) ⬇️
integration 60.41% <75.00%> (+0.01%) ⬆️
unit 23.01% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the reasons behind the init coding choices (see my comments).

cmd/ferretdb/dummy.go Outdated Show resolved Hide resolved
cmd/ferretdb/main.go Outdated Show resolved Hide resolved
cmd/ferretdb/pg.go Outdated Show resolved Hide resolved
cmd/ferretdb/main.go Outdated Show resolved Hide resolved
Building without it produces a much smaller binary.
seeforschauer
seeforschauer previously approved these changes Jun 6, 2022
Co-authored-by: Elena Grahovac <elena@grahovac.me>
rumyantseva
rumyantseva previously approved these changes Jun 7, 2022
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/ferretdb/main.go Outdated Show resolved Hide resolved
Co-authored-by: Elena Grahovac <elena@grahovac.me>
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit c959f2d into FerretDB:main Jun 7, 2022
@AlekSi AlekSi deleted the enable-tigris-handler branch June 7, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants