Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $all array query operator #724

Merged
merged 79 commits into from
Jul 21, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Jun 9, 2022

Description

This PR closes #657.

The implementation is the same as for the other filter operators. We validate if the doc matches the conditions set in $all.

Testing

Two types of tests are added:

  • Integration tests for $all operator
  • Compat tests for $all operator

If you see that some test cases might be missing, please let me know.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

rumyantseva and others added 30 commits May 31, 2022 14:52
Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
@rumyantseva rumyantseva changed the title [DRAFT] Support $all array query operator Support $all array query operator Jul 20, 2022
@rumyantseva rumyantseva marked this pull request as ready for review July 20, 2022 16:43
@rumyantseva rumyantseva requested a review from a team as a code owner July 20, 2022 16:43
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi added this to the v0.5.1 milestone Jul 21, 2022
@AlekSi AlekSi merged commit 6101b4f into FerretDB:main Jul 21, 2022
@rumyantseva rumyantseva deleted the issue-255-support-all branch August 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support $all array query operator
4 participants