-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build .rpm and .deb packages #739
Conversation
Codecov Report
@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 59.19% 59.13% -0.06%
==========================================
Files 225 225
Lines 10020 10020
==========================================
- Hits 5931 5925 -6
- Misses 3394 3398 +4
- Partials 695 697 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…e-734-buildRpmDeb
…e-734-buildRpmDeb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#739 is |
Actually, why we need |
We are satisfied with the file "ferretdb_v0.4.0-56-g15af921-dirty.deb"? |
"dirty" means that there are some changes that are not committed yet. That should not happen on CI where we build committed (and pushed) changes. So yes, that's fine, because that will not happen in practice. No need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also tweak CI config to build package there, just for testing for now, without actually uploading them anywhere
Thank you! |
Closes #734.