Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build .rpm and .deb packages #739

Merged
merged 30 commits into from
Jul 17, 2022
Merged

Conversation

fenogentov
Copy link
Contributor

Closes #734.

@fenogentov fenogentov requested a review from AlekSi as a code owner June 15, 2022 16:17
@fenogentov fenogentov marked this pull request as draft June 15, 2022 16:17
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #739 (c0b0149) into main (fb56a54) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   59.19%   59.13%   -0.06%     
==========================================
  Files         225      225              
  Lines       10020    10020              
==========================================
- Hits         5931     5925       -6     
- Misses       3394     3398       +4     
- Partials      695      697       +2     
Impacted Files Coverage Δ
internal/handlers/pg/msg_dbstats.go 65.11% <0.00%> (-6.98%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
Flag Coverage Δ
integration 61.20% <ø> (-0.07%) ⬇️
mongodb 18.46% <ø> (-0.04%) ⬇️
pg 61.13% <ø> (-0.07%) ⬇️
unit 24.65% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Taskfile.yml Outdated Show resolved Hide resolved
Taskfile.yml Outdated Show resolved Hide resolved
@fenogentov fenogentov marked this pull request as ready for review June 28, 2022 03:55
@AlekSi AlekSi self-requested a review June 29, 2022 17:13
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 29, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jun 29, 2022
Taskfile.yml Outdated Show resolved Hide resolved
@fenogentov fenogentov requested a review from AlekSi July 6, 2022 04:47
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fenogentov
Copy link
Contributor Author

#739 (comment)

#739 is Merged
it got me confused

@AlekSi
Copy link
Member

AlekSi commented Jul 9, 2022

Actually, why we need grep at all? Version generated by git describe --tags --dirty should be good enough

@AlekSi AlekSi modified the milestones: v0.5.0, v0.5.1 Jul 10, 2022
@fenogentov
Copy link
Contributor Author

Actually, why we need grep at all? Version generated by git describe --tags --dirty should be good enough

We are satisfied with the file "ferretdb_v0.4.0-56-g15af921-dirty.deb"?
Or is it "ferretdb_v0.4.0-56-g15af921.deb"?

@AlekSi
Copy link
Member

AlekSi commented Jul 11, 2022

We are satisfied with the file "ferretdb_v0.4.0-56-g15af921-dirty.deb"?

"dirty" means that there are some changes that are not committed yet. That should not happen on CI where we build committed (and pushed) changes.

So yes, that's fine, because that will not happen in practice. No need to grep or anything

@fenogentov fenogentov requested a review from AlekSi July 11, 2022 11:14
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also tweak CI config to build package there, just for testing for now, without actually uploading them anywhere

Taskfile.yml Outdated Show resolved Hide resolved
Taskfile.yml Outdated Show resolved Hide resolved
@fenogentov fenogentov requested a review from AlekSi July 16, 2022 11:12
@AlekSi AlekSi merged commit 22f1fdb into FerretDB:main Jul 17, 2022
@AlekSi
Copy link
Member

AlekSi commented Jul 17, 2022

Thank you!

@w84thesun w84thesun mentioned this pull request Dec 21, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build .rpm and .deb packages
2 participants