Drop test_db
#788
Merged
Drop test_db
#788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not using it much now, but it makes `task env-up` much slower.
AlekSi
commented
Jun 23, 2022
Comment on lines
-324
to
-340
| var portsCheckError error | ||
|
|
||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
|
|
||
| logger.Info("Waiting for port 37017 to be up...") | ||
| portsCheckError = waitForPort(portsCtx, 37017) | ||
| }() | ||
|
|
||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
|
|
||
| logger.Info("Waiting for port 5432 to be up...") | ||
| portsCheckError = waitForPostgresPort(portsCtx, 5432) | ||
| }() |
There was a problem hiding this comment.
Among other things, there was a data race – two goroutines assigned to the same variable portsCheckError
Codecov Report
@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 59.27% 59.27%
=======================================
Files 212 212
Lines 9348 9348
=======================================
Hits 5541 5541
Misses 3163 3163
Partials 644 644
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
requested review from
a team,
seeforschauer and
noisersup
and removed request for
a team
|
We never had |
noisersup
approved these changes
Jun 24, 2022
seeforschauer
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not using it much now, but it makes
task env-upmuch slower.Checklist
task allpasses.See CONTRIBUTING.md for more details.