Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.head_ref instead of github.ref #814

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 30, 2022

The latter is the base reference (in most cases, main branch) for pull_request_target.
It canceled this workflow for other PRs.

The latter is the base reference (in most cases, `main` branch) for `pull_request_target`.
It canceled this workflow for other PRs.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 30, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jun 30, 2022
@AlekSi AlekSi self-assigned this Jun 30, 2022
@AlekSi AlekSi requested review from a team, w84thesun, seeforschauer and noisersup and removed request for a team June 30, 2022 18:42
@AlekSi AlekSi enabled auto-merge (squash) June 30, 2022 18:43
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #814 (c8e6af4) into main (12e85df) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   59.59%   59.56%   -0.04%     
==========================================
  Files         216      216              
  Lines        9475     9475              
==========================================
- Hits         5647     5644       -3     
- Misses       3175     3177       +2     
- Partials      653      654       +1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
Flag Coverage Δ
FerretDB 62.05% <ø> (-0.04%) ⬇️
MongoDB 7.42% <ø> (-0.04%) ⬇️
integration 62.15% <ø> (-0.04%) ⬇️
unit 27.57% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge June 30, 2022 21:22
@AlekSi AlekSi merged commit 00b3001 into FerretDB:main Jun 30, 2022
@AlekSi AlekSi deleted the base_ref branch June 30, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants