Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export integration tests helpers #838

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Export integration tests helpers #838

merged 2 commits into from
Jul 4, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 4, 2022

They are needed for Tigris integration.

They are needed for Tigris integration.
@AlekSi AlekSi requested a review from rumyantseva as a code owner July 4, 2022 16:28
@AlekSi AlekSi enabled auto-merge (squash) July 4, 2022 16:29
@AlekSi AlekSi requested review from a team, w84thesun and noisersup and removed request for a team July 4, 2022 16:29
@AlekSi AlekSi self-assigned this Jul 4, 2022
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 4, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #838 (d61f9e8) into main (4ddc06b) will increase coverage by 29.37%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #838       +/-   ##
===========================================
+ Coverage   29.70%   59.08%   +29.37%     
===========================================
  Files         217      217               
  Lines        9817     9817               
===========================================
+ Hits         2916     5800     +2884     
+ Misses       6438     3306     -3132     
- Partials      463      711      +248     
Impacted Files Coverage Δ
integration/setup.go 84.09% <75.00%> (+28.03%) ⬆️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/bson/document.go 47.09% <0.00%> (+0.68%) ⬆️
internal/types/document.go 85.02% <0.00%> (+1.79%) ⬆️
internal/types/types.go 85.88% <0.00%> (+2.35%) ⬆️
integration/helpers.go 85.41% <0.00%> (+2.77%) ⬆️
internal/types/path.go 84.21% <0.00%> (+4.21%) ⬆️
internal/handlers/pg/pgdb/settings.go 37.20% <0.00%> (+6.97%) ⬆️
internal/clientconn/conn.go 46.38% <0.00%> (+10.26%) ⬆️
internal/types/compare_order.go 82.50% <0.00%> (+11.25%) ⬆️
... and 55 more
Flag Coverage Δ
FerretDB 61.29% <75.00%> (?)
MongoDB 7.23% <75.00%> (-0.04%) ⬇️
integration 61.39% <75.00%> (+54.11%) ⬆️
unit 27.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit f63ba4d into FerretDB:main Jul 4, 2022
@AlekSi AlekSi deleted the export branch July 4, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants