Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill MongoDB on task env-data too #860

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 7, 2022

Description

Helpful for experiments.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 7, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jul 7, 2022
@AlekSi AlekSi self-assigned this Jul 7, 2022
@AlekSi AlekSi requested review from a team, w84thesun, seeforschauer and noisersup and removed request for a team July 7, 2022 06:25
@AlekSi AlekSi enabled auto-merge (squash) July 7, 2022 06:25
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #860 (9582fb0) into main (ccd2844) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   59.09%   59.08%   -0.02%     
==========================================
  Files         218      218              
  Lines        9841     9841              
==========================================
- Hits         5816     5815       -1     
- Misses       3316     3317       +1     
  Partials      709      709              
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/clientconn/conninfo/conn_info.go 83.33% <0.00%> (+16.66%) ⬆️
Flag Coverage Δ
integration 61.63% <ø> (+0.10%) ⬆️
mongodb 18.79% <ø> (-0.04%) ⬇️
pg 61.56% <ø> (+0.10%) ⬆️
unit 24.35% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 4dfa92f into FerretDB:main Jul 7, 2022
@AlekSi AlekSi deleted the mongo-data branch July 7, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants