Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 42P07 PostgreSQL error to fix the tests #895

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Jul 15, 2022

Description

This PR is created to fix failing tests on main, e.g. here.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Jul 15, 2022
@rumyantseva rumyantseva requested a review from a team July 15, 2022 13:05
@rumyantseva rumyantseva requested a review from a team as a code owner July 15, 2022 13:05
@rumyantseva rumyantseva self-assigned this Jul 15, 2022
@rumyantseva rumyantseva requested a review from AlekSi July 15, 2022 13:05
@rumyantseva rumyantseva enabled auto-merge (squash) July 15, 2022 13:05
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #895 (34bb02d) into main (6071465) will decrease coverage by 2.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   61.24%   59.15%   -2.10%     
==========================================
  Files         182      225      +43     
  Lines        8605    10020    +1415     
==========================================
+ Hits         5270     5927     +657     
- Misses       2690     3399     +709     
- Partials      645      694      +49     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/collections.go 53.04% <0.00%> (+5.21%) ⬆️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/tigris/msg_dbstats.go 0.00% <0.00%> (ø)
...nal/handlers/tigris/msg_getfreemonitoringstatus.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_findandmodify.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_ismaster.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_datasize.go 0.00% <0.00%> (ø)
internal/tjson/tjson.go 51.77% <0.00%> (ø)
internal/handlers/tigris/msg_dropdatabase.go 0.00% <0.00%> (ø)
internal/tjson/int32.go 45.45% <0.00%> (ø)
... and 89 more
Flag Coverage Δ
integration 61.49% <0.00%> (+0.25%) ⬆️
mongodb 18.44% <0.00%> (-0.06%) ⬇️
pg 61.42% <0.00%> (+0.25%) ⬆️
unit 24.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Handle 42P07 pg error to fix the tests Handle 42P07 PostgreSQL error to fix the tests Jul 15, 2022
@AlekSi AlekSi added this to the v0.5.1 milestone Jul 15, 2022
@AlekSi AlekSi disabled auto-merge July 15, 2022 13:41
@AlekSi AlekSi enabled auto-merge (squash) July 15, 2022 13:41
@AlekSi AlekSi added no ci and removed no ci labels Jul 15, 2022
@AlekSi AlekSi disabled auto-merge July 15, 2022 14:04
@AlekSi AlekSi merged commit fb56a54 into FerretDB:main Jul 15, 2022
@rumyantseva rumyantseva deleted the fix-tests branch August 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants