Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for a database name border case #921

Merged
merged 7 commits into from
Jul 21, 2022
Merged

Add test for a database name border case #921

merged 7 commits into from
Jul 21, 2022

Conversation

seeforschauer
Copy link
Contributor

@seeforschauer seeforschauer commented Jul 20, 2022

Description

This PR closes #807.

  • fix typo in documentation
  • add test border case 63 and 64 letters in a database name.
  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@seeforschauer seeforschauer changed the title Validate database names Validate database names: add test for border case Jul 20, 2022
@seeforschauer seeforschauer changed the title Validate database names: add test for border case Add test for a database name border case Jul 20, 2022
@seeforschauer seeforschauer self-assigned this Jul 20, 2022
@seeforschauer seeforschauer added the code/enhancement Some user-visible feature could work better label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #921 (5ed1e9f) into main (c75a8ae) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
- Coverage   59.71%   59.68%   -0.03%     
==========================================
  Files         224      224              
  Lines       10200    10200              
==========================================
- Hits         6091     6088       -3     
- Misses       3399     3401       +2     
- Partials      710      711       +1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
Flag Coverage Δ
integration 61.91% <ø> (-0.04%) ⬇️
mongodb 19.05% <ø> (-0.04%) ⬇️
pg 61.80% <ø> (-0.04%) ⬇️
tigris 49.75% <ø> (ø)
unit 25.04% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@seeforschauer seeforschauer marked this pull request as ready for review July 20, 2022 11:43
@seeforschauer seeforschauer requested review from a team and AlekSi as code owners July 20, 2022 11:43
w84thesun
w84thesun previously approved these changes Jul 20, 2022
@seeforschauer seeforschauer enabled auto-merge (squash) July 20, 2022 14:11
@AlekSi
Copy link
Member

AlekSi commented Jul 20, 2022

I marked all done items in this checklist.

Please don't ignore the checklist we all wanted to introduce

@AlekSi AlekSi added this to the v0.5.1 milestone Jul 20, 2022
@AlekSi AlekSi requested a review from w84thesun July 21, 2022 12:15
@seeforschauer seeforschauer merged commit c50afb5 into FerretDB:main Jul 21, 2022
@seeforschauer seeforschauer deleted the issue-807-validate-db-names branch July 21, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate database names
3 participants