-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port and sync unit testing approach from fjson
to tjson
#935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 62.40% 62.57% +0.16%
==========================================
Files 225 225
Lines 10444 10444
==========================================
+ Hits 6518 6535 +17
+ Misses 3155 3138 -17
Partials 771 771
Flags with carried forward coverage won't be shown. Click here to find out more. |
fjson
to tjson
fjson
to tjson
w84thesun
previously approved these changes
Jul 26, 2022
AlekSi
reviewed
Jul 26, 2022
…B into issue-899-port-tests
w84thesun
approved these changes
Jul 26, 2022
AlekSi
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #899.
This PR contains the simplest test cases migrated from
fjson
.More complicated cases (e.g. invalid schema) should be covered separately.
Readiness checklist
task all
, and it passed.task godocs
.