Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port and sync unit testing approach from fjson to tjson #935

Merged
merged 13 commits into from
Jul 26, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Jul 22, 2022

Description

This PR closes #899.

This PR contains the simplest test cases migrated from fjson.
More complicated cases (e.g. invalid schema) should be covered separately.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/enhancement Some user-visible feature could work better label Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #935 (7921f08) into main (c0fa49b) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   62.40%   62.57%   +0.16%     
==========================================
  Files         225      225              
  Lines       10444    10444              
==========================================
+ Hits         6518     6535      +17     
+ Misses       3155     3138      -17     
  Partials      771      771              
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/databases.go 54.66% <0.00%> (-5.34%) ⬇️
internal/handlers/pg/pgdb/collections.go 54.86% <0.00%> (-5.31%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/msg_dbstats.go 72.09% <0.00%> (+6.97%) ⬆️
internal/tjson/tjson.go 66.66% <0.00%> (+7.80%) ⬆️
internal/tjson/int64.go 59.09% <0.00%> (+13.63%) ⬆️
internal/tjson/double.go 59.09% <0.00%> (+13.63%) ⬆️
internal/tjson/bool.go 45.45% <0.00%> (+45.45%) ⬆️
Flag Coverage Δ
integration 57.28% <ø> (ø)
mongodb 18.80% <ø> (-0.04%) ⬇️
pg 62.41% <ø> (ø)
tigris 18.31% <ø> (-0.03%) ⬇️
unit 24.50% <ø> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v0.6.0 milestone Jul 25, 2022
@rumyantseva rumyantseva requested review from a team, AlekSi, w84thesun and noisersup and removed request for a team July 25, 2022 23:47
@rumyantseva rumyantseva marked this pull request as ready for review July 25, 2022 23:47
@rumyantseva rumyantseva requested a review from a team as a code owner July 25, 2022 23:47
@rumyantseva rumyantseva changed the title [DRAFT] Port and sync unit testing approach from fjson to tjson Port and sync unit testing approach from fjson to tjson Jul 25, 2022
w84thesun
w84thesun previously approved these changes Jul 26, 2022
@AlekSi AlekSi modified the milestones: v0.6.0, v0.5.1 Jul 26, 2022
@AlekSi AlekSi enabled auto-merge (squash) July 26, 2022 06:25
@AlekSi AlekSi modified the milestones: v0.5.1, v0.6.0 Jul 26, 2022
@rumyantseva rumyantseva requested a review from AlekSi July 26, 2022 07:28
@AlekSi AlekSi modified the milestones: v0.6.0, v0.5.1 Jul 26, 2022
@AlekSi AlekSi merged commit 0918eb9 into FerretDB:main Jul 26, 2022
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/enhancement Some user-visible feature could work better labels Jul 26, 2022
@rumyantseva rumyantseva deleted the issue-899-port-tests branch August 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tjson: Port and sync unit testing approach from fjson to tjson
3 participants