Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nModified count for update's $set operator with the same value #949

Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jul 27, 2022

Description

This PR closes #571.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/bug Some user-visible feature works incorrectly label Jul 27, 2022
@w84thesun w84thesun added this to the v0.6.0 milestone Jul 27, 2022
@w84thesun w84thesun self-assigned this Jul 27, 2022
@w84thesun w84thesun changed the title WIP Fix nModified count for update's $set operator with the same value Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #949 (1a7ebf9) into main (0a45d81) will decrease coverage by 0.02%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   61.97%   61.95%   -0.03%     
==========================================
  Files         228      228              
  Lines       10591    10597       +6     
==========================================
+ Hits         6564     6565       +1     
- Misses       3252     3255       +3     
- Partials      775      777       +2     
Impacted Files Coverage Δ
internal/handlers/common/update.go 85.61% <62.50%> (-0.42%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/collections.go 57.52% <0.00%> (-2.66%) ⬇️
internal/handlers/pg/msg_dbstats.go 72.09% <0.00%> (+6.97%) ⬆️
Flag Coverage Δ
integration 56.67% <62.50%> (+<0.01%) ⬆️
mongodb 18.61% <0.00%> (-0.07%) ⬇️
pg 61.62% <62.50%> (+<0.01%) ⬆️
tigris 18.25% <0.00%> (+0.04%) ⬆️
unit 24.27% <0.00%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun marked this pull request as ready for review July 27, 2022 09:09
@w84thesun w84thesun requested a review from a team as a code owner July 27, 2022 09:09
@w84thesun w84thesun requested review from AlekSi, rumyantseva, a team and noisersup and removed request for a team July 27, 2022 09:09
@AlekSi AlekSi merged commit 9e5b193 into FerretDB:main Jul 27, 2022
@w84thesun w84thesun deleted the issue-571-fix-update-nModified-response-field branch August 4, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update's nModified is incorrect in some cases
3 participants