Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document return values of embedded as experimental / may change #922

Closed
KnutAM opened this issue May 19, 2024 · 0 comments · Fixed by #959
Closed

Document return values of embedded as experimental / may change #922

KnutAM opened this issue May 19, 2024 · 0 comments · Fixed by #959
Milestone
v1.0.0

Comments

@KnutAM
Copy link
Member

KnutAM commented May 19, 2024

Currently, calling e.g. shape_gradient on AbstracValues for embedded elements returns a StaticArray. I would suggest to document this as experimental, since we aim to have MixedTensors (Ferrite-FEM/Tensors.jl#188) as return value in the future.

Ref discussion here: #857

Adding this as a todo before releasing 1.0. I don't think it is reasonable to have MixedTensors in Tensors.jl before Ferrite 1.0, since that PR would benefit from other WIP, especially Ferrite-FEM/Tensors.jl#211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Warn about SArray output from embedded FEValues Ferrite-FEM/Ferrite.jl
1 participant
@KnutAM