Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about SArray output from embedded FEValues #959

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented May 29, 2024

Closes #922

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (a12ae02) to head (471ec03).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
- Coverage   93.71%   93.69%   -0.03%     
==========================================
  Files          36       36              
  Lines        5313     5438     +125     
==========================================
+ Hits         4979     5095     +116     
- Misses        334      343       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnutAM KnutAM added this to the v1.0.0 milestone Jun 6, 2024
@KnutAM KnutAM added the awaiting review PR is finished from the authors POV, waiting for feedback label Jun 6, 2024
@fredrikekre fredrikekre merged commit c5f8c97 into master Jun 9, 2024
10 of 11 checks passed
@fredrikekre fredrikekre deleted the kam/embedded_experimental_api_notice branch June 9, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR is finished from the authors POV, waiting for feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document return values of embedded as experimental / may change
3 participants