start docs for MixedDofHandler #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnutAM
reviewed
Feb 24, 2022
| @@ -1,15 +1,30 @@ | |||
| """ | |||
| Field(name::Symbol, interpolation::Interpolation, dim::Int) | |||
There was a problem hiding this comment.
Suggested change
| Field(name::Symbol, interpolation::Interpolation, dim::Int) | |
| Field(name::Symbol, interpolation::Interpolation, dim::Int) |
Noticed formatting missing while reading the preview doc...
|
I guess the long term goal is now to keep both handlers as separate entities? |
|
This PR isn't supposed to make a decision on that, it would still be nice to join them to one |
fredrikekre
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A start to add some documentation for the
MixedDofHandler. TheCommon methodssection could still use some love, just added the docstrings that were already there in the code.