Handle prescribed dofs in RHS of affine constraints #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/untangle
branch
2 times, most recently
from
b659a9e
to
dd02160
Compare
Codecov ReportBase: 92.31% // Head: 92.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 92.31% 92.37% +0.05%
==========================================
Files 22 22
Lines 3776 3805 +29
==========================================
+ Hits 3486 3515 +29
Misses 290 290
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fredrikekre
force-pushed
the
fe/untangle
branch
3 times, most recently
from
58f570b
to
47cf270
Compare
lijas
reviewed
Nov 9, 2022
This patch fixes affine constraints with prescribed dofs in the RHS. In
particular, we allow dofs that are prescribed by just an inhomogeneity
(i.e. DBC) but disallow "nesting" affine constraints.
Concretely, consider e.g. the following two constraints:
u2 = f(t)
u3 = u2 + b3
Before this patch this was not handled correctly since the inhomogeneity
for u3 was taken as b3, but it should really be b3 + f(t) by
substituting u2 for f(t). Since we allow for time-dependent
inhomogeneities this substitution can not be done in
close!(::ConstraintHandler) and instead the effective inhomogeneity is
computed in update!.
Nested constraints, e.g.
u2 = u3
u3 = u5
are still not allowed but in the future this can be resolved in
close!(::ConstraintHandler) to
u2 = u5
u3 = u5
However, this patch checks for such nesting and raises an error instead
of resulting in incorrect answers as is the case before.
Fixes #530.
fredrikekre
force-pushed
the
fe/untangle
branch
from
47cf270
to
d68f9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes affine constraints with prescribed dofs in the RHS. In particular, we allow dofs that are prescribed by just an inhomogeneity (i.e. DBC) but disallow "nesting" affine constraints.
Concretely, consider e.g. the following two constraints:
Before this patch this was not handled correctly since the inhomogeneity for
u3was taken asb3, but it should really beb3 + f(t)by substitutingu2forf(t). Since we allow for time-dependent inhomogeneities this substitution has to be done at runtime and not duringclose!(::ConstraintHandler).Nested constraints, e.g.
are still not allowed but in the future this can be resolved in
close!(::ConstraintHandler)toHowever, this patch checks for such nesting and raises an error instead of resulting in incorrect answers as is the case before.
Fixes #530.