Remove grid representation from MixedDofHandler
#577
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 92.97% 92.73% -0.24%
==========================================
Files 28 28
Lines 4270 4185 -85
==========================================
- Hits 3970 3881 -89
- Misses 300 304 +4
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
After this PR, what else is missing to merge the dof handlers? A convenience wrapper aroung add which internally adds the field handler and then? |
fredrikekre
force-pushed
the
ka/remove_grid_representation_from_mixeddh
branch
from
5eeb36d
to
aac45c1
Compare
Since #577 the CellVector struct does not seem necessary anymore since it is only used in one place for dof storage. This patch removes the struct and inlines the fields directly in the MixedDofHandler struct instead, similar to the DofHandler struct. Also removes some duplicate code for celldofs(...).
Since #577 the CellVector struct does not seem necessary anymore since it is only used in one place for dof storage. This patch removes the struct and inlines the fields directly in the MixedDofHandler struct instead, similar to the DofHandler struct. Also removes some duplicate code for celldofs(...).
After #536 and #576, there is no need for the extra grid representation in the
MixedDofHandleranymore (compare especially the benchmarks in #536).