Update dof storage in MixedDofHandler #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #577 the CellVector struct does not seem necessary anymore since it is only used in one place for dof storage. This patch removes the struct and inlines the fields directly in the MixedDofHandler struct instead, similar to the DofHandler struct. Also removes some duplicate code for celldofs(...).
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 29 29
Lines 4445 4432 -13
=======================================
- Hits 4108 4096 -12
+ Misses 337 336 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kimauth
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #577 the CellVector struct does not seem necessary anymore since it is only used in one place for dof storage. This patch removes the struct and inlines the fields directly in the MixedDofHandler struct instead, similar to the DofHandler struct. Also removes some duplicate code for celldofs(...).