Fix constraint condensation for Symmetric matrices.
#592
Conversation
Codecov ReportBase: 92.76% // Head: 92.79% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 92.76% 92.79% +0.02%
==========================================
Files 28 28
Lines 4203 4217 +14
==========================================
+ Hits 3899 3913 +14
Misses 304 304
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Small suggestion here, maybe it makes sense to split up the function into two (one for Symmetric one for SparseMatrixCSC) instead of putting the branches in the existing function. |
This patch fixes an issue where `f` would be incorrectly modified in `apply!(K, f, ch)` when `K::Symmetric` and when using inhomogeneous constraints. Specifically this patch make sure that entries below the diagonal of the matrix backing the `Symmetric` aren't used, and that the corresponding entries from above the diagonal are used in their place.
fredrikekre
force-pushed
the
fe/applysym
branch
from
a9ef642
to
98d327b
Compare
|
The rest of the method is the same though, so I think that would give more code duplication. I don't think the branch is too bad. |
This patch fixes an issue where
fwould be incorrectly modified inapply!(K, f, ch)whenK::Symmetricand when using inhomogeneous constraints. Specifically this patch make sure that entries below the diagonal of the matrix backing theSymmetricaren't used, and that the corresponding entries from above the diagonal are used in their place.