Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DofHandler and MixedDofHandler #667

Merged
merged 19 commits into from
Apr 3, 2023
Merged

Conversation

kimauth
Copy link
Member

@kimauth kimauth commented Apr 3, 2023

After a series of previous PRs, the MixedDofHandler is now equally performant as the DofHandler in all performance critical parts of the code base (see #629).

This PR removes DofHandler and those code paths that specialised for it. MixedDofHandler is renamed to DofHandler.

This should represent a non-breaking change for users using DofHandler. Users using MixedDofHandler need to rename all occurrences of MixedDofHandler to DofHandler, but their code should keep working otherwise.

closes #624

@fredrikekre
Copy link
Member

Run git mv src/Dofs/MixedDofHandler.jl src/Dofs/DofHandler.jl too?

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 94.52% and project coverage change: +0.14 🎉

Comparison is base (539e49e) 92.99% compared to head (fbc1b9b) 93.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   92.99%   93.14%   +0.14%     
==========================================
  Files          30       29       -1     
  Lines        4499     4273     -226     
==========================================
- Hits         4184     3980     -204     
+ Misses        315      293      -22     
Impacted Files Coverage Δ
ext/FerriteBlockArrays.jl 86.66% <ø> (ø)
ext/FerriteMetis.jl 100.00% <ø> (ø)
src/Ferrite.jl 100.00% <ø> (ø)
src/Grid/grid.jl 90.36% <ø> (-0.53%) ⬇️
src/Dofs/DofHandler.jl 94.19% <94.02%> (+10.04%) ⬆️
src/Dofs/ConstraintHandler.jl 94.79% <100.00%> (-1.05%) ⬇️
src/Dofs/DofRenumbering.jl 91.39% <100.00%> (-0.10%) ⬇️
src/Dofs/apply_analytical.jl 100.00% <100.00%> (+1.81%) ⬆️
src/Dofs/sparsity_pattern.jl 99.27% <100.00%> (ø)
src/L2_projection.jl 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fredrikekre
Copy link
Member

dh::Union{DofHandler,MixedDofHandler},

@fredrikekre fredrikekre merged commit 6a518e5 into master Apr 3, 2023
@fredrikekre fredrikekre deleted the ka/remove_dofhandler branch April 3, 2023 13:20
@fredrikekre
Copy link
Member

Thanks @kimauth for the herculean effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging DofHandler and MixedDofHandler
4 participants