-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge DofHandler
and MixedDofHandler
#667
Conversation
…ior compared to old DofHandler.
Run |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 92.99% 93.14% +0.14%
==========================================
Files 30 29 -1
Lines 4499 4273 -226
==========================================
- Hits 4184 3980 -204
+ Misses 315 293 -22
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Ferrite.jl/ext/FerriteMetis.jl Line 32 in b2b86dd
|
Thanks @kimauth for the herculean effort! |
After a series of previous PRs, the
MixedDofHandler
is now equally performant as theDofHandler
in all performance critical parts of the code base (see #629).This PR removes
DofHandler
and those code paths that specialised for it.MixedDofHandler
is renamed toDofHandler
.This should represent a non-breaking change for users using
DofHandler
. Users usingMixedDofHandler
need to rename all occurrences ofMixedDofHandler
toDofHandler
, but their code should keep working otherwise.closes #624