Much needed features for a modpack of mine #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2019 17:45
Full rework and CraftTweaker, JEI and TOP integrations for Steam Turbine, Boiler and Alternator. Config file now affects even more aspects of the mod.
|
I have merged this in to ModTweaker, please do NOT merge this PR, it WILL cause issues when both mods are loaded since they use the same ZenClass package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immersive Tech is an amazing mod but the lack of proper ways to configure it made me decide to rework some features and add CraftTweaker integration, along with some other ideas I thought would be good additions to the base mod.
Steam Turbine now needs to speed up first before it can reach full potential, its animation is based on current speed. It features an output pipe in case modpack creators want to return stuff like water vapor. TOP integration also shows current speed and torque. JEI integration shows not only what different kinds of steam it accepts, but also how long they last and whether or not there's an output fluid.
Alternator had many bugs in its code, so I decided to do a complete rewrite of how it produces power. Power generation is based on current speed * torque.
Boiler now has a "heat level" meter, which needs to be filled up by burning fuel to then start producing steam. Also features TOP integration to display said meter. Revamped JEI integration to now show how long it takes to complete recipes and which fuels are accepted in the boiler.
Config file was dramatically changed, both because CraftTweaker makes some of the options irrelevant but also because of much needed features, such as disabling certain machines and recipes, not to mention more straightforward ways of choosing power generation, efficiency and so on.
The manual has been updated to reflect all changes. Tons of bugs have been squashed, and performance gains should be perceptible when it comes to memory usage, since the mod now does way less instantiations and actually caches many variables that keep being reused all the time.
I'm thinking of reworking the distiller and solar tower next, but might take some time...