Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact resize_mode #8

Merged
merged 2 commits into from
Jul 20, 2022
Merged

refact resize_mode #8

merged 2 commits into from
Jul 20, 2022

Conversation

thiagofloriano
Copy link
Contributor

No description provided.

@thiagofloriano thiagofloriano self-assigned this Jul 20, 2022
@thiagofloriano thiagofloriano marked this pull request as draft July 20, 2022 17:39
@thiagofloriano thiagofloriano marked this pull request as ready for review July 20, 2022 17:41
Copy link
Member

@brenogazzola brenogazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cria um teste no variable_test por favor. Eu obviamente esqueci quando eu acrescentei o resize_mode como atributo

@brenogazzola
Copy link
Member

Pode ser simples:

blob = create_file_blob(filename: "dog.jpg", content_type: "image/jpg", metadata: { analyzed: true, width: 1401, height: 2102, white_background: white_background })
image = VitalsImage::Optimizer::Variable.new(blob, width: width, height: height, resize_mode: BLABLABLA)
assert_equal BLABLABLA, image.send(:resize_mode)
end

@brenogazzola brenogazzola merged commit 868e575 into main Jul 20, 2022
@brenogazzola brenogazzola deleted the vin-701 branch July 20, 2022 18:51
@thiagofloriano thiagofloriano changed the title refact (vin-701) resize_mode refact resize_mode Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants