redundant variable should ignore large expressions

Feuermagier · Apr 2, 2024 · 7625570 · 7625570
1 parent efb3bb8
commit 7625570
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...er-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariable.java b/...er-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariable.java
@@ -21,6 +21,8 @@
 
 @ExecutableCheck(reportedProblems = {ProblemType.REDUNDANT_VARIABLE})
 public class RedundantVariable extends IntegratedCheck {
+    private static final int MAX_EXPRESSION_SIZE = 40;
+
     /**
      * Checks if the given statement does not influence the variable returned by the return statement.
      *
@@ -32,7 +34,7 @@ private boolean isAllowedStatement(CtStatement ctStatement) {
     }
 
     private boolean isComplexExpression(CtExpression<?> ctExpression) {
-        return ctExpression instanceof CtSwitchExpression<?,?>;
+        return ctExpression instanceof CtSwitchExpression<?,?> || ctExpression.toString().length() > MAX_EXPRESSION_SIZE;
     }
 
     private void checkVariableRead(CtStatement ctStatement, CtVariableRead<?> ctVariableRead) {