Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a class creates an unmodifiable collection in all constructors, it should not have to provide copies in the getter, but in the setter #441

Closed
Luro02 opened this issue Feb 15, 2024 · 0 comments · Fixed by #503
Closed

When a class creates an unmodifiable collection in all constructors, it should not have to provide copies in the getter, but in the setter #441

Luro02 opened this issue Feb 15, 2024 · 0 comments · Fixed by #503
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Feb 15, 2024

Summary

Similar to what is intended for records, this should work for classes as well.

Lint Name

LIST_NOT_COPIED_IN_GETTER

Reproducer

<code>
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. labels Feb 15, 2024
Luro02 added a commit to Luro02/autograder that referenced this issue Apr 23, 2024
@Luro02
rewrite getter/setter check and rename it to LeakedCollectionCheck F…
6fc515b 
…euermagier#412 Feuermagier#441 Feuermagier#440 Feuermagier#439 Feuermagier#438 Feuermagier#437
@Luro02 Luro02 mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement some things Luro02/autograder
1 participant
@Luro02